Skip to content

fix(mcp): prevent agent hang by checking session closure state #1396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ratish1 wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −1
Open

fix(mcp): prevent agent hang by checking session closure state #1396

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/strands/tools/mcp/mcp_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -801,4 +801,10 @@ def _matches_patterns(self, tool: MCPAgentTool, patterns: list[_ToolMatcher]) ->
return False

def _is_session_active(self) -> bool:
return self._background_thread is not None and self._background_thread.is_alive()
if self._background_thread is None or not self._background_thread.is_alive():
return False

if self._close_future is not None and self._close_future.done():
return False

return True