fix(gemini): UnboundLocal Exception Fix #1420
Conversation
Initialize candidate and event variables to None to prevent UnboundLocalError when stream yields no events. Also conditionally yield metadata only when event exists.
Add test case that reproduces UnboundLocalError when Gemini stream yields no events. Without proper initialization of candidate and event variables, an empty stream causes UnboundLocalError.
emattiza
temporarily deployed
to
manual-approval
GitHub Actions
Inactive
dbschmigelski
left a comment
dbschmigelski
left a comment
There was a problem hiding this comment.
Hi, thanks for raising this! I am inclined to approve to fix the immediate issue.
I am curious if this is emitting the contentBlockStart is incorrect in this scenario though. It does appear consistent with what we are doing with other models though.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Yeah this seems very weird edge case wise and there may be some ulterior reason why the event stream is empty. FWIW, it ran 32k invocations through this workflow across tool calls and hit this maybe once or twice, so may chalk up to llm silliness that this ever happens to begin with. Thank you! |
3 participants
Description
At runtime, when the Gemini model returns an empty async event stream, the current code references local variables only declared and initialized in the body of the event stream for loop. This cause an UnboundLocal exception to be raised consistent with #1402
Related Issues
#1402
Documentation PR
Type of Change
Bug fix
Testing
How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli
hatch run prepareChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.