Skip to content

feat: add concurrent S3 message reading to list_messages #1422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Unshure wants to merge 2 commits into from
Closed

feat: add concurrent S3 message reading to list_messages #1422

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
163a7e9
feat: add concurrent S3 message reading to list_messages
strands-agent Jan 5, 2026
c2f94e9
Additional changes from write operations
strands-agent Jan 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Empty file added =2.11.0
View file
Open in desktop
Empty file.
34 changes: 34 additions & 0 deletions aiobotocore_install.log
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
Collecting aiobotocore
Downloading aiobotocore-3.1.0-py3-none-any.whl.metadata (26 kB)
Requirement already satisfied: aiohttp<4.0.0,>=3.12.0 in /opt/hostedtoolcache/Python/3.13.11/x64/lib/python3.13/site-packages (from aiobotocore) (3.13.3)
Collecting aioitertools<1.0.0,>=0.5.1 (from aiobotocore)
Downloading aioitertools-0.13.0-py3-none-any.whl.metadata (3.3 kB)
Collecting botocore<1.42.20,>=1.41.0 (from aiobotocore)
Downloading botocore-1.42.19-py3-none-any.whl.metadata (5.9 kB)
Requirement already satisfied: python-dateutil<3.0.0,>=2.1 in /opt/hostedtoolcache/Python/3.13.11/x64/lib/python3.13/site-packages (from aiobotocore) (2.9.0.post0)
Requirement already satisfied: jmespath<2.0.0,>=0.7.1 in /opt/hostedtoolcache/Python/3.13.11/x64/lib/python3.13/site-packages (from aiobotocore) (1.0.1)
Requirement already satisfied: multidict<7.0.0,>=6.0.0 in /opt/hostedtoolcache/Python/3.13.11/x64/lib/python3.13/site-packages (from aiobotocore) (6.7.0)
Requirement already satisfied: wrapt<3.0.0,>=1.10.10 in /opt/hostedtoolcache/Python/3.13.11/x64/lib/python3.13/site-packages (from aiobotocore) (1.17.3)
Requirement already satisfied: aiohappyeyeballs>=2.5.0 in /opt/hostedtoolcache/Python/3.13.11/x64/lib/python3.13/site-packages (from aiohttp<4.0.0,>=3.12.0->aiobotocore) (2.6.1)
Requirement already satisfied: aiosignal>=1.4.0 in /opt/hostedtoolcache/Python/3.13.11/x64/lib/python3.13/site-packages (from aiohttp<4.0.0,>=3.12.0->aiobotocore) (1.4.0)
Requirement already satisfied: attrs>=17.3.0 in /opt/hostedtoolcache/Python/3.13.11/x64/lib/python3.13/site-packages (from aiohttp<4.0.0,>=3.12.0->aiobotocore) (25.4.0)
Requirement already satisfied: frozenlist>=1.1.1 in /opt/hostedtoolcache/Python/3.13.11/x64/lib/python3.13/site-packages (from aiohttp<4.0.0,>=3.12.0->aiobotocore) (1.8.0)
Requirement already satisfied: propcache>=0.2.0 in /opt/hostedtoolcache/Python/3.13.11/x64/lib/python3.13/site-packages (from aiohttp<4.0.0,>=3.12.0->aiobotocore) (0.4.1)
Requirement already satisfied: yarl<2.0,>=1.17.0 in /opt/hostedtoolcache/Python/3.13.11/x64/lib/python3.13/site-packages (from aiohttp<4.0.0,>=3.12.0->aiobotocore) (1.22.0)
Requirement already satisfied: urllib3!=2.2.0,<3,>=1.25.4 in /opt/hostedtoolcache/Python/3.13.11/x64/lib/python3.13/site-packages (from botocore<1.42.20,>=1.41.0->aiobotocore) (2.6.2)
Requirement already satisfied: six>=1.5 in /opt/hostedtoolcache/Python/3.13.11/x64/lib/python3.13/site-packages (from python-dateutil<3.0.0,>=2.1->aiobotocore) (1.17.0)
Requirement already satisfied: idna>=2.0 in /opt/hostedtoolcache/Python/3.13.11/x64/lib/python3.13/site-packages (from yarl<2.0,>=1.17.0->aiohttp<4.0.0,>=3.12.0->aiobotocore) (3.11)
Downloading aiobotocore-3.1.0-py3-none-any.whl (87 kB)
Downloading aioitertools-0.13.0-py3-none-any.whl (24 kB)
Downloading botocore-1.42.19-py3-none-any.whl (14.6 MB)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 14.6/14.6 MB 126.9 MB/s 0:00:00
Installing collected packages: aioitertools, botocore, aiobotocore
Attempting uninstall: botocore
Found existing installation: botocore 1.42.21
Uninstalling botocore-1.42.21:
Successfully uninstalled botocore-1.42.21

ERROR: pip's dependency resolver does not currently take into account all the packages that are installed. This behaviour is the source of the following dependency conflicts.
strands-agents-tools 0.2.19 requires strands-agents>=1.0.0, but you have strands-agents 0.1.dev1+g695ca6654 which is incompatible.
boto3 1.42.21 requires botocore<1.43.0,>=1.42.21, but you have botocore 1.42.19 which is incompatible.
Successfully installed aiobotocore-3.1.0 aioitertools-0.13.0 botocore-1.42.19
54 changes: 54 additions & 0 deletions dev_install_output.log
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
Collecting pytest
Downloading pytest-9.0.2-py3-none-any.whl.metadata (7.6 kB)
Collecting pytest-asyncio
Downloading pytest_asyncio-1.3.0-py3-none-any.whl.metadata (4.1 kB)
Collecting moto
Downloading moto-5.1.19-py3-none-any.whl.metadata (12 kB)
Requirement already satisfied: boto3 in /opt/hostedtoolcache/Python/3.13.11/x64/lib/python3.13/site-packages (1.42.21)
Collecting iniconfig>=1.0.1 (from pytest)
Downloading iniconfig-2.3.0-py3-none-any.whl.metadata (2.5 kB)
Requirement already satisfied: packaging>=22 in /opt/hostedtoolcache/Python/3.13.11/x64/lib/python3.13/site-packages (from pytest) (25.0)
Collecting pluggy<2,>=1.5 (from pytest)
Using cached pluggy-1.6.0-py3-none-any.whl.metadata (4.8 kB)
Requirement already satisfied: pygments>=2.7.2 in /opt/hostedtoolcache/Python/3.13.11/x64/lib/python3.13/site-packages (from pytest) (2.19.2)
Requirement already satisfied: botocore!=1.35.45,!=1.35.46,>=1.20.88 in /opt/hostedtoolcache/Python/3.13.11/x64/lib/python3.13/site-packages (from moto) (1.42.21)
Requirement already satisfied: cryptography>=35.0.0 in /opt/hostedtoolcache/Python/3.13.11/x64/lib/python3.13/site-packages (from moto) (46.0.3)
Requirement already satisfied: requests>=2.5 in /opt/hostedtoolcache/Python/3.13.11/x64/lib/python3.13/site-packages (from moto) (2.32.5)
Collecting xmltodict (from moto)
Downloading xmltodict-1.0.2-py3-none-any.whl.metadata (15 kB)
Collecting werkzeug!=2.2.0,!=2.2.1,>=0.5 (from moto)
Downloading werkzeug-3.1.4-py3-none-any.whl.metadata (4.0 kB)
Requirement already satisfied: python-dateutil<3.0.0,>=2.1 in /opt/hostedtoolcache/Python/3.13.11/x64/lib/python3.13/site-packages (from moto) (2.9.0.post0)
Collecting responses!=0.25.5,>=0.15.0 (from moto)
Downloading responses-0.25.8-py3-none-any.whl.metadata (47 kB)
Collecting Jinja2>=2.10.1 (from moto)
Downloading jinja2-3.1.6-py3-none-any.whl.metadata (2.9 kB)
Requirement already satisfied: six>=1.5 in /opt/hostedtoolcache/Python/3.13.11/x64/lib/python3.13/site-packages (from python-dateutil<3.0.0,>=2.1->moto) (1.17.0)
Requirement already satisfied: jmespath<2.0.0,>=0.7.1 in /opt/hostedtoolcache/Python/3.13.11/x64/lib/python3.13/site-packages (from boto3) (1.0.1)
Requirement already satisfied: s3transfer<0.17.0,>=0.16.0 in /opt/hostedtoolcache/Python/3.13.11/x64/lib/python3.13/site-packages (from boto3) (0.16.0)
Requirement already satisfied: urllib3!=2.2.0,<3,>=1.25.4 in /opt/hostedtoolcache/Python/3.13.11/x64/lib/python3.13/site-packages (from botocore!=1.35.45,!=1.35.46,>=1.20.88->moto) (2.6.2)
Requirement already satisfied: cffi>=2.0.0 in /opt/hostedtoolcache/Python/3.13.11/x64/lib/python3.13/site-packages (from cryptography>=35.0.0->moto) (2.0.0)
Requirement already satisfied: pycparser in /opt/hostedtoolcache/Python/3.13.11/x64/lib/python3.13/site-packages (from cffi>=2.0.0->cryptography>=35.0.0->moto) (2.23)
Collecting MarkupSafe>=2.0 (from Jinja2>=2.10.1->moto)
Downloading markupsafe-3.0.3-cp313-cp313-manylinux2014_x86_64.manylinux_2_17_x86_64.manylinux_2_28_x86_64.whl.metadata (2.7 kB)
Requirement already satisfied: charset_normalizer<4,>=2 in /opt/hostedtoolcache/Python/3.13.11/x64/lib/python3.13/site-packages (from requests>=2.5->moto) (3.4.4)
Requirement already satisfied: idna<4,>=2.5 in /opt/hostedtoolcache/Python/3.13.11/x64/lib/python3.13/site-packages (from requests>=2.5->moto) (3.11)
Requirement already satisfied: certifi>=2017.4.17 in /opt/hostedtoolcache/Python/3.13.11/x64/lib/python3.13/site-packages (from requests>=2.5->moto) (2026.1.4)
Collecting pyyaml (from responses!=0.25.5,>=0.15.0->moto)
Downloading pyyaml-6.0.3-cp313-cp313-manylinux2014_x86_64.manylinux_2_17_x86_64.manylinux_2_28_x86_64.whl.metadata (2.4 kB)
Downloading pytest-9.0.2-py3-none-any.whl (374 kB)
Using cached pluggy-1.6.0-py3-none-any.whl (20 kB)
Downloading pytest_asyncio-1.3.0-py3-none-any.whl (15 kB)
Downloading moto-5.1.19-py3-none-any.whl (6.5 MB)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 6.5/6.5 MB 97.8 MB/s 0:00:00
Downloading iniconfig-2.3.0-py3-none-any.whl (7.5 kB)
Downloading jinja2-3.1.6-py3-none-any.whl (134 kB)
Downloading markupsafe-3.0.3-cp313-cp313-manylinux2014_x86_64.manylinux_2_17_x86_64.manylinux_2_28_x86_64.whl (22 kB)
Downloading responses-0.25.8-py3-none-any.whl (34 kB)
Downloading werkzeug-3.1.4-py3-none-any.whl (224 kB)
Downloading pyyaml-6.0.3-cp313-cp313-manylinux2014_x86_64.manylinux_2_17_x86_64.manylinux_2_28_x86_64.whl (801 kB)
━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 801.6/801.6 kB 97.5 MB/s 0:00:00
Downloading xmltodict-1.0.2-py3-none-any.whl (13 kB)
Installing collected packages: xmltodict, pyyaml, pluggy, MarkupSafe, iniconfig, werkzeug, responses, pytest, Jinja2, pytest-asyncio, moto

Successfully installed Jinja2-3.1.6 MarkupSafe-3.0.3 iniconfig-2.3.0 moto-5.1.19 pluggy-1.6.0 pytest-9.0.2 pytest-asyncio-1.3.0 pyyaml-6.0.3 responses-0.25.8 werkzeug-3.1.4 xmltodict-1.0.2
47 changes: 47 additions & 0 deletions full_test_output.log
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
============================= test session starts ==============================
platform linux -- Python 3.13.11, pytest-9.0.2, pluggy-1.6.0 -- /opt/hostedtoolcache/Python/3.13.11/x64/bin/python
cachedir: .pytest_cache
rootdir: /home/runner/work/sdk-python/sdk-python
configfile: pyproject.toml
plugins: anyio-4.12.0, asyncio-1.3.0
asyncio: mode=Mode.STRICT, debug=False, asyncio_default_fixture_loop_scope=function, asyncio_default_test_loop_scope=function
collecting ... collected 36 items

tests/strands/session/test_s3_session_manager.py::test_init_s3_session_manager PASSED [ 2%]
tests/strands/session/test_s3_session_manager.py::test_init_s3_session_manager_with_config PASSED [ 5%]
tests/strands/session/test_s3_session_manager.py::test_init_s3_session_manager_with_existing_user_agent PASSED [ 8%]
tests/strands/session/test_s3_session_manager.py::test_create_session PASSED [ 11%]
tests/strands/session/test_s3_session_manager.py::test_create_session_already_exists PASSED [ 13%]
tests/strands/session/test_s3_session_manager.py::test_read_session PASSED [ 16%]
tests/strands/session/test_s3_session_manager.py::test_read_nonexistent_session PASSED [ 19%]
tests/strands/session/test_s3_session_manager.py::test_delete_session PASSED [ 22%]
tests/strands/session/test_s3_session_manager.py::test_create_agent PASSED [ 25%]
tests/strands/session/test_s3_session_manager.py::test_read_agent PASSED [ 27%]
tests/strands/session/test_s3_session_manager.py::test_read_nonexistent_agent PASSED [ 30%]
tests/strands/session/test_s3_session_manager.py::test_update_agent PASSED [ 33%]
tests/strands/session/test_s3_session_manager.py::test_update_nonexistent_agent PASSED [ 36%]
tests/strands/session/test_s3_session_manager.py::test_create_message PASSED [ 38%]
tests/strands/session/test_s3_session_manager.py::test_read_message PASSED [ 41%]
tests/strands/session/test_s3_session_manager.py::test_read_nonexistent_message PASSED [ 44%]
tests/strands/session/test_s3_session_manager.py::test_list_messages_all PASSED [ 47%]
tests/strands/session/test_s3_session_manager.py::test_list_messages_with_pagination PASSED [ 50%]
tests/strands/session/test_s3_session_manager.py::test_update_message PASSED [ 52%]
tests/strands/session/test_s3_session_manager.py::test_update_nonexistent_message PASSED [ 55%]
tests/strands/session/test_s3_session_manager.py::test__get_session_path_invalid_session_id[a/../b] PASSED [ 58%]
tests/strands/session/test_s3_session_manager.py::test__get_session_path_invalid_session_id[a/b] PASSED [ 61%]
tests/strands/session/test_s3_session_manager.py::test__get_agent_path_invalid_agent_id[a/../b] PASSED [ 63%]
tests/strands/session/test_s3_session_manager.py::test__get_agent_path_invalid_agent_id[a/b] PASSED [ 66%]
tests/strands/session/test_s3_session_manager.py::test__get_message_path_invalid_message_id[../../../secret] PASSED [ 69%]
tests/strands/session/test_s3_session_manager.py::test__get_message_path_invalid_message_id[../../attack] PASSED [ 72%]
tests/strands/session/test_s3_session_manager.py::test__get_message_path_invalid_message_id[../escape] PASSED [ 75%]
tests/strands/session/test_s3_session_manager.py::test__get_message_path_invalid_message_id[path/traversal] PASSED [ 77%]
tests/strands/session/test_s3_session_manager.py::test__get_message_path_invalid_message_id[not_an_int] PASSED [ 80%]
tests/strands/session/test_s3_session_manager.py::test__get_message_path_invalid_message_id[None] PASSED [ 83%]
tests/strands/session/test_s3_session_manager.py::test__get_message_path_invalid_message_id[message_id6] PASSED [ 86%]
tests/strands/session/test_s3_session_manager.py::test_create_multi_agent PASSED [ 88%]
tests/strands/session/test_s3_session_manager.py::test_read_multi_agent PASSED [ 91%]
tests/strands/session/test_s3_session_manager.py::test_read_nonexistent_multi_agent PASSED [ 94%]
tests/strands/session/test_s3_session_manager.py::test_update_multi_agent PASSED [ 97%]
tests/strands/session/test_s3_session_manager.py::test_update_nonexistent_multi_agent PASSED [100%]

============================== 36 passed in 8.10s ==============================
Loading
Loading