Skip to content

fix: Update finalize condition for workflow execution#1708

Open
Unshure wants to merge 2 commits intostrands-agents:mainfrom
Unshure:main
Open

fix: Update finalize condition for workflow execution#1708
Unshure wants to merge 2 commits intostrands-agents:mainfrom
Unshure:main

Conversation

@Unshure
Copy link
Member

@Unshure Unshure commented Feb 16, 2026

Run Strands command only for valid invocations since we are getting failed workflows for no reason

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Only run finalize for a valid invocation, not always
@codecov
Copy link

codecov bot commented Feb 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

pgrayy
pgrayy previously approved these changes Feb 16, 2026
@github-actions
Copy link

Assessment: Request Changes

The intent to filter out invalid workflow runs is good, but removing always() changes cleanup behavior.

Review Details
  • Behavior Change: Without always(), the finalize job won't run if upstream jobs fail, which could prevent cleanup operations
  • Suggestion: Use always() && (condition) to get both filtering and guaranteed cleanup

Thanks for addressing the workflow noise issue!

@github-actions
Copy link

Assessment: Approve ✅

The updated change correctly addresses both concerns:

  • Filters workflow runs to only valid Strands commands
  • Preserves cleanup behavior with always() when upstream jobs fail

LGTM!

@Unshure Unshure changed the title Update finalize condition for workflow execution fix: Update finalize condition for workflow execution Feb 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants