fix: Update finalize condition for workflow execution#1708
Open
Unshure wants to merge 2 commits intostrands-agents:mainfrom
Open
fix: Update finalize condition for workflow execution#1708Unshure wants to merge 2 commits intostrands-agents:mainfrom
Unshure wants to merge 2 commits intostrands-agents:mainfrom
Conversation
Only run finalize for a valid invocation, not always
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
pgrayy
previously approved these changes
Feb 16, 2026
|
Assessment: Request Changes The intent to filter out invalid workflow runs is good, but removing Review Details
Thanks for addressing the workflow noise issue! |
Unshure
commented
Feb 16, 2026
|
Assessment: Approve ✅ The updated change correctly addresses both concerns:
LGTM! |
JackYPCOnline
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run Strands command only for valid invocations since we are getting failed workflows for no reason
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.