Skip to content

Conversation

@schleidl
Copy link
Contributor

@schleidl schleidl commented Jul 22, 2025

Description

Changed the litellm model provider to handle non-streaming responses fixing issue #477

Related Issues

Documentation PR

Type of Change

Bug fix

Testing

How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli

  • I ran hatch run prepare

Checklist

  • I have read the CONTRIBUTING document
  • I have added any necessary tests that prove my fix is effective or my feature works
  • I have updated the documentation accordingly
  • I have added an appropriate example to the documentation to outline the feature, or no new docs are needed
  • My changes generate no new warnings
  • Any dependent changes have been merged and published

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@schleidl schleidl changed the title Litellm handle non streaming response fix for issue #477 fix! Litellm handle non streaming response fix for issue #477 Jul 22, 2025
@zastrowm zastrowm added the area-provider Related to model providers label Jul 22, 2025
Copy link

@dkmiller dkmiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you so much for the fix 🎉!

@schleidl
Copy link
Contributor Author

schleidl commented Aug 5, 2025

Hi all! Please consider this pull request for review.
@zastrowm @zastrowm @clareliguori @signoredems

@dbschmigelski
Copy link
Member

Hey, thanks for this, we actually just merged #1183 and would love to get this in as the long term fix.

Sorry for the delay on this, I'll be looking at this this week.

Before reviewing though, I see that you marked the commit message with fix!, can you describe why this is breaking first to help me review?

@schleidl
Copy link
Contributor Author

Hi, nothing is breaking. The fix! was a mistake. Thanks for working on it!

Copy link
Contributor

@mkmeral mkmeral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we merge from main, and then followup on the comments? There are some updates to litellm that we should follow here (e.g. log styling, exception handling, etc)

@dbschmigelski dbschmigelski force-pushed the litellm-handle-non-streaming-response branch from a06ee6e to 0ffc14c Compare January 5, 2026 15:02
@github-actions github-actions bot added the size/m label Jan 5, 2026
@codecov
Copy link

codecov bot commented Jan 5, 2026

Codecov Report

❌ Patch coverage is 91.01124% with 8 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/strands/models/litellm.py 91.01% 1 Missing and 7 partials ⚠️

📢 Thoughts on this report? Let us know!

@dbschmigelski
Copy link
Member

Updated to reduce duplication

@dbschmigelski dbschmigelski merged commit 2f04bc0 into strands-agents:main Jan 8, 2026
18 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-provider Related to model providers size/l

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants