-
Notifications
You must be signed in to change notification settings - Fork 593
fix! Litellm handle non streaming response fix for issue #477 #512
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix! Litellm handle non streaming response fix for issue #477 #512
Conversation
dkmiller
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you so much for the fix 🎉!
|
Hi all! Please consider this pull request for review. |
|
Hey, thanks for this, we actually just merged #1183 and would love to get this in as the long term fix. Sorry for the delay on this, I'll be looking at this this week. Before reviewing though, I see that you marked the commit message with |
|
Hi, nothing is breaking. The fix! was a mistake. Thanks for working on it! |
mkmeral
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we merge from main, and then followup on the comments? There are some updates to litellm that we should follow here (e.g. log styling, exception handling, etc)
a06ee6e to
0ffc14c
Compare
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
Updated to reduce duplication |
Description
Changed the litellm model provider to handle non-streaming responses fixing issue #477
Related Issues
Documentation PR
Type of Change
Bug fix
Testing
How have you tested the change? Verify that the changes do not break functionality or introduce warnings in consuming repositories: agents-docs, agents-tools, agents-cli
hatch run prepareChecklist
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.