Dev/update cache manager #108
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o easily import them
…one at a later stage
…port questions on the documentation website
…n-rest-cache into dev/v5-docs
…-cache into dev/update-cache-manager
Contributor
|
Stacked is an understatement lol. Thanks Boaz I'll try and take a look today/this week. Got sidetracked last week. |
…m the root of the repository
…n-rest-cache into dev/v5-docs
…-cache into dev/update-cache-manager
Contributor
|
@boazpoolman Do we still need this PR or did the other one contain these changes? |
Contributor
|
Ah nvm I see #109 was branched off this, so gonna close this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a stacked PR, branched off of
dev/v5-docs.This PR updates cache-manager to version 7, integrating Keyv storage adapters.
Memory provider
The memory provider now uses quick-lru as it's Keyv storage adapter. My plan was to have cache-manager use it's default memory provider (
CacheableMemory), but that caused issues when trying to find the keys in the cache (source).Using quick-lru allowed me to move past this issue, and seeing how Keyv recommends quick-lru as an external storage adapter it seemed like the right thing to do.
Redis provider
The Redis provider now uses the native
@keyv/redisadapter locked at version 3. The reason for that is starting from version 4 they have replacediorediswith@redis/client. That makes it incompatible with the Strapi Redis plugin which is built on top of ioredis.Ideally we can remove the version constraint of
@keyv/rediseventually, but that would require the Redis plugin to migrate to the new Redis client. I've opened an issue for that on the Redis plugin repo for that.