Skip to content

Rename identifier for clarity #1226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mulkieran merged 1 commit into from
Sep 29, 2025
Merged

Rename identifier for clarity #1226

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/stratis_cli/_actions/_list_filesystem.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ def list_filesystems(
)
requires_unique = fs_id is not None

path_to_name = dict(
pool_object_path_to_pool_name = dict(
(path, MOPool(info).Name())
for path, info in pools(props=props).search(managed_objects)
)
Expand All @@ -74,13 +74,13 @@ def list_filesystems(
klass = Table(
uuid_formatter,
filesystems_with_props,
path_to_name,
pool_object_path_to_pool_name,
)
else:
klass = Detail(
uuid_formatter,
filesystems_with_props,
path_to_name,
pool_object_path_to_pool_name,
)

klass.display()
Expand All @@ -95,7 +95,7 @@ def __init__(
self,
uuid_formatter: Callable,
filesystems_with_props: List[Any],
path_to_name: Dict[ObjectPath, String],
pool_object_path_to_pool_name: Dict[ObjectPath, String],
):
"""
Initialize a List object.
Expand All @@ -105,7 +105,7 @@ def __init__(
"""
self.uuid_formatter = uuid_formatter
self.filesystems_with_props = filesystems_with_props
self.path_to_name = path_to_name
self.pool_object_path_to_pool_name = pool_object_path_to_pool_name

@abstractmethod
def display(self):
Expand Down Expand Up @@ -141,7 +141,7 @@ def filesystem_size_quartet(dbus_props):

tables = [
(
self.path_to_name[mofilesystem.Pool()],
self.pool_object_path_to_pool_name[mofilesystem.Pool()],
mofilesystem.Name(),
filesystem_size_quartet(mofilesystem),
mofilesystem.Devnode(),
Expand Down Expand Up @@ -187,7 +187,7 @@ def display(self):

print(f"UUID: {self.uuid_formatter(fs.Uuid())}")
print(f"Name: {fs.Name()}")
print(f"Pool: {self.path_to_name[fs.Pool()]}")
print(f"Pool: {self.pool_object_path_to_pool_name[fs.Pool()]}")
print()
print(f"Device: {fs.Devnode()}")
print()
Expand Down
Loading