Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 26, 2025

Summary

Addresses feedback on PR #3309 to use a more specific logger identifier in test utilities, avoiding ambiguity with the source file's logger.

Changes

  • Changed logger identifier from 'utils' to 'sdk-test-utils' in packages/sdk/test/test-utils/utils.ts

This prevents confusion in logs between the test utilities logger and the identically-named logger in packages/sdk/src/utils/utils.ts.

Checklist before requesting a review

  • Is this a breaking change? If it is, be clear in summary.
  • Read through code myself one more time.
  • Make sure any and all TODO comments left behind are meant to be left in.
  • Has reasonable passing test coverage?
  • Updated changelog if applicable.
  • Updated documentation if applicable.

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.


Note

  • Logging: Update Logger name in packages/sdk/test/test-utils/utils.ts from utils to sdk-test-utils to disambiguate test logs from source utils logger.

Written by Cursor Bugbot for commit 9ae3c3a. This will update automatically on new commits. Configure here.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Co-authored-by: mondoreale <320066+mondoreale@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Dec 26, 2025

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • https://storage.googleapis.com/chrome-for-testing-public/121.0.6167.184/linux64/chromedriver-linux64.zip
    • Triggering command: /usr/local/bin/node node install.js (http block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Refactor to avoid NodeJS-specific module usage Change logger identifier from 'utils' to 'sdk-test-utils' for clarity Dec 26, 2025
Copilot AI requested a review from mondoreale December 26, 2025 18:17
@mondoreale mondoreale marked this pull request as ready for review December 26, 2025 18:17
@mondoreale mondoreale merged commit 160b9d9 into avoid-nodejs-module Dec 26, 2025
1 check passed
@mondoreale mondoreale deleted the copilot/sub-pr-3309-again branch December 26, 2025 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants