Skip to content

refactor: Use explicit module names instead of module for logging (round 2) #3317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mondoreale merged 3 commits into from
Dec 26, 2025
+5 −5
Merged

refactor: Use explicit module names instead of module for logging (round 2) #3317

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7e5523c
Missed a spot
mondoreale Dec 26, 2025
022dde5
1 more
mondoreale Dec 26, 2025
9511d6c
Fix tests
mondoreale Dec 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/dht/src/connection/webrtc/WebrtcConnector.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import { acceptHandshake, createIncomingHandshaker, createOutgoingHandshaker, re
import { isMaybeSupportedProtocolVersion } from '../../helpers/version'
import { PendingConnection } from '../PendingConnection'

const logger = new Logger(module)
const logger = new Logger('WebrtcConnector')

export const replaceInternalIpWithExternalIp = (candidate: string, ip: string): string => {
const parsed = candidate.split(' ')
Expand Down
2 changes: 1 addition & 1 deletion packages/sdk/test/browser-smoke-test/server.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ const path = require('path')
const express = require('express')
const { Logger } = require('@streamr/utils')

const logger = new Logger(module)
const logger = new Logger('browser-smoke-test/server')
const app = express()

app.use('/static', express.static(path.join(__dirname, '/../../dist')))
Expand Down
6 changes: 3 additions & 3 deletions packages/utils/test/Logger.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ describe('Logger', () => {
logs.push(pick(JSON.parse(data), ['level', 'msg']))
}
}
logger = new Logger('Logger', undefined, 'trace', pino({
logger = new Logger('Logger.test', undefined, 'trace', pino({
level: 'trace',
browser: {
write: (o) => {
Expand Down Expand Up @@ -83,14 +83,14 @@ describe('Logger', () => {
const expected = typeof _streamr_electron_test === 'undefined'
? 'Logger.test '
: 'Logger.test'
expect(Logger.createName(module)).toBe(expected)
expect(Logger.createName('Logger.test.ts')).toBe(expected)
})
it('application id', () => {
const expected = typeof _streamr_electron_test === 'undefined'
? 'APP:Logger.test '
: 'APP:Logger.test'
process.env.STREAMR_APPLICATION_ID = 'APP'
expect(Logger.createName(module)).toBe(expected)
expect(Logger.createName('Logger.test.ts')).toBe(expected)
delete process.env.STREAMR_APPLICATION_ID
})
it('index', () => {
Expand Down