Skip to content

Notifier Worker #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sujanadiga wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Notifier Worker #4

sujanadiga wants to merge 2 commits into from

Conversation

@sujanadiga
Copy link
Collaborator

@sujanadiga sujanadiga commented Jul 4, 2024 •
edited
Loading

Changes:

  • Add base for polling from SQS
  • Update task_execs in DB
  • Send notifications if applicable

stuckinforloop
stuckinforloop reviewed Jul 4, 2024
View reviewed changes
internal/task_exec/task_exec.go
messageId, message, err := dao.Queue.Dequeue(ctx, NotifierQueueName, 30)
if err != nil {
dao.Logger.Error("Dequeue failed", zap.Error(err))
continue // Continue to retry
Copy link
Owner

@stuckinforloop stuckinforloop Jul 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we need to put a limit on this in future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stuckinforloop stuckinforloop stuckinforloop left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sujanadiga @stuckinforloop