fix(ui): use picker.select instead of vim.ui.select to fix snacks picker bug #174
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue with Snacks.nvim picker when using
vim.ui.select. The bug causes an "Invalid 'height': Number is not integral" depending on the picker's config.Related issue: folke/snacks.nvim#2539
Changes
picker.select()function that uses Snacks.picker directly when Snacks is the preferred picker, bypassing the buggyvim.ui.selectimplementationvim.ui.selectto respect user customizations (e.g., dressing.nvim)vim.ui.selectcalls withpicker.select()in files that use selection UIFiles Changed
lua/opencode/ui/picker.lua- Addedselect()and_snacks_select()functionslua/opencode/api.lua- Usepicker.selectfor agent selectionlua/opencode/provider.lua- Usepicker.selectfor model selectionlua/opencode/git_review.lua- Usepicker.selectfor file selectionlua/opencode/ui/input_window.lua- Usepicker.selectfor confirmation promptslua/opencode/ui/ui.lua- Usepicker.selectfor session selection