Add a slim builder that doesn't call to_string right away#12
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12 +/- ##
===========================================
- Coverage 100.00% 92.62% -7.38%
===========================================
Files 1 2 +1
Lines 171 393 +222
===========================================
+ Hits 171 364 +193
- Misses 0 29 +29 ☔ View full report in Codecov by Sentry. |
20da7e5 to
9fe6196
Compare
9fe6196 to
d58a2e3
Compare
d58a2e3 to
8722770
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses the ideas behind #6. It uses a recursive type construction outlined in this gist and can deal with any type (and type reference).