fix(web3): normalize Ethereum addresses to lowercase to prevent case-… #2265
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for spotting the issue & contributing the fix @lingcoder ! Can you please also update the test? auth/internal/utilities/siwe/parser_test.go Line 119 in 9f39cad |
lingcoder
force-pushed
the
feature/fix-siwe
branch
from
3d55a11 to
776d2c6
Compare
![depthfirst-app[bot]](https://avatars.githubusercontent.com/in/1021002?s=60&v=4){kind=small}
lingcoder
force-pushed
the
feature/fix-siwe
branch
from
cd7781a to
43314eb
Compare
Contributor
|
Hello! I reviewed this PR again and a quick note on the migration.
What about skipping the bulk backfill and whoever needs backfilling can run manual queries? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…sensitivity issues #2264
What kind of change does this PR introduce?
Bug fix, feature, docs update, ...
What is the current behavior?
Please link any relevant issues here.
What is the new behavior?
Feel free to include screenshots if it includes visual changes.
Additional context
Add any other context or screenshots.