fix: ensure we do not duplicate bubble text #1934
Conversation
palmer-cl
commented
Feb 4, 2026
palmer-cl
commented
- The document nodes are the source of truth for what appears in the editor, so they should define the comment text.
- Also keep the fallbacks
- added tests
caio-pizzol
left a comment
caio-pizzol
left a comment
There was a problem hiding this comment.
clean one @palmer-cl!
the only addition I would say here is that in this case, it also impacts rendering and interactions with the editor. we should definitely write interaction stories and upload a sample file for visual testing.
| if (!hasInsertNode && nodes?.length) fallbackNodes.push(...nodes); | ||
| if (!hasDeleteNode && deletionNodes?.length) fallbackNodes.push(...deletionNodes); | ||
|
|
||
| // Remove duplicates by comparing node identity |
There was a problem hiding this comment.
this comment is stale -- the Set isn't doing the heavy lifting anymore, the conditional above is. maybe just drop the comment or change to // safety net for identity dedup
There was a problem hiding this comment.
Updated comment!
| node.marks.find((nodeMark) => nodeMark.type.name === TrackDeleteMarkName), | ||
| ); | ||
|
|
||
| const fallbackNodes = []; |
There was a problem hiding this comment.
could be one expression but reads fine either way -- no strong opinion
There was a problem hiding this comment.
added as one expression .
|
@caio-pizzol added VRTs and updated comments. |
3 participants
