[8.6] Add clamp function
#554
Open
+264
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
That would be for PHP 8.6, isn't it? |
stof
reviewed
Nov 19, 2025
Author
Correct, moving it. |
kylekatarnls
force-pushed
the
feature/clamp
branch
2 times, most recently
from
5bbf49c to
d88b259
Compare
kylekatarnls
force-pushed
the
feature/clamp
branch
3 times, most recently
from
bead94d to
c9033e5
Compare
kylekatarnls
force-pushed
the
feature/clamp
branch
from
248a2dc to
236eb98
Compare
kylekatarnls
force-pushed
the
feature/clamp
branch
from
236eb98 to
daaa8bb
Compare
Author
|
php/php-src#19434 is merged (will land in PHP 8.6) |
Comment on lines
+22
to
+31
| * @template V | ||
| * @template L | ||
| * @template H | ||
| * | ||
| * @param V $value | ||
| * @param L $min | ||
| * @param H $max | ||
| * | ||
| * @return V|L|H | ||
| */ |
Member
There was a problem hiding this comment.
What's the logic behind L and H? Maybe this could be more explanatory with TVal, TMin, TMax.
Author
There was a problem hiding this comment.
L = Low, H = High.
It was because min and max both start with an M.
But I'm fine using full words such as Value, Minimum, Maximum.
Comment on lines
+34
to
+40
| if (\is_float($min) && \is_nan($min)) { | ||
| self::throwValueErrorIfAvailable('clamp(): Argument #2 ($min) cannot be NAN'); | ||
| } | ||
|
|
||
| if (\is_float($max) && is_nan($max)) { | ||
| self::throwValueErrorIfAvailable('clamp(): Argument #3 ($max) cannot be NAN'); | ||
| } |
Member
There was a problem hiding this comment.
It was merged using must in the wording, it should be updated here as well. See https://github.com/php/php-src/blob/f80338cb926a6dbe8007ad62776bdb4f8d6dd047/ext/standard/math.c#L393-L403
Co-authored-by: Alexandre Daubois <2144837+alexandre-daubois@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RFC: https://wiki.php.net/rfc/clamp_v2
Original implementation: php/php-src#19434
Documentation: php/doc-en#4814