Migarate from Flowbite avatar into Shadcn avatar #135
Conversation
| function getDisplayName(user?: SessionUser | null) { | ||
| if (user?.name && user.name.trim().length > 0) return user.name; | ||
| if (user?.email) { | ||
| const localPart = user.email.split('@')[0] ?? user.email; | ||
| return localPart || user.email; | ||
| } | ||
| return m.user_fallback(); | ||
| } | ||
There was a problem hiding this comment.
More code - more potential issue. Idea is to keep it simple and streightforward, limited to component and no functional changes. Kindly follow the previous implementation, if otherwise you have a very strong reason to add new "lines"
| alt={getDisplayName(page.data.session.user)} | ||
| /> | ||
| <AvatarFallback> | ||
| {getInitials(page.data.session.user?.name ?? page.data.session.user?.email ?? null)} |
There was a problem hiding this comment.
Please use the name only. We have bigger problems upstreams if we are not getting it tbh 👨🏻💻
aryadhruv
left a comment
aryadhruv
left a comment
There was a problem hiding this comment.
Great start ! A few changes.
Idea is to keep the changes and scope of PR limited to components migration. Thanks !
|
@shkelqim627 Let's merge this post #136 , ensuring that the button for dark mode and the avatar box has the same height. |
|
@shkelqim627 Almost there, I think all that's necessary is to resolve your first merge conflict! 🤞🏼 It does seem there are formatting issues (have you enabled commit hooks? Ref: https://moonrepo.dev/docs/guides/vcs-hooks), particularly in your second commit, which might be the cause of the merge conflict in the first place. Here's how I would address it:
IF this is succesfull, you can force-push, removing your old messy commits, replacing them by a single clean one which should merge just fine. Let us know (here) if you run into any issues with that! |
|
P.S. There was an issue causing Github Actions/CI not to be run. These have since been resolved and automated checks should now inform you of any formatting or linter issues. |
3 participants
Replaced the Flowbite Avatar component with the new Shadcn Avatar component across the codebase.
Let me know if anything needs adjustment!