Skip to content

feat: centralize money formatting logic #671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ovitrif merged 5 commits into from
Jan 19, 2026
Merged

feat: centralize money formatting logic #671

ovitrif merged 5 commits into from
Jan 19, 2026

Conversation

@ovitrif
Copy link
Collaborator

@ovitrif ovitrif commented Jan 19, 2026 •
edited
Loading

This PR centralizes how monetary values are formatted in error messages.

Description

  • Formats shortfall amounts in error toasts according to user's display unit preference
  • Supports both Modern (sats with space grouping) and Classic (BTC with decimals) formats
  • Uses device locale for consistent number formatting

Preview

Modern Classic
format.mp4
classic.mp4

QA Notes

1. Modern Display

  1. Set display unit to Modern in Settings
  2. Scan a Lightning invoice exceeding your balance
  3. Verify the error toast shows the shortfall with space grouping (e.g., "1 000 000")

2. Classic Display

  1. Switch to Classic display unit
  2. Trigger the same error
  3. Verify the amount shows as BTC decimals (e.g., "0.01000000")

Note

Merge this PR only AFTER merging the PR of its target branch:

  • 625

@ovitrif ovitrif changed the base branch from master to fix/address-validation January 19, 2026 15:35
@ovitrif ovitrif changed the title feat: address validation with formatted errors feat: add FormatMoneyValue use case Jan 19, 2026
@ovitrif ovitrif changed the title feat: add FormatMoneyValue use case feat: centralize money formatting logic Jan 19, 2026
@ovitrif ovitrif marked this pull request as ready for review January 19, 2026 15:49
@ovitrif ovitrif mentioned this pull request Jan 19, 2026
Merged
Base automatically changed from fix/address-validation to master January 19, 2026 15:52
@claude

This comment has been minimized.

Sign in to view
@ovitrif ovitrif enabled auto-merge January 19, 2026 15:55
@ovitrif ovitrif mentioned this pull request Jan 19, 2026
Draft
ben-kaufman
ben-kaufman approved these changes Jan 19, 2026
View reviewed changes
Copy link
Contributor

@ben-kaufman ben-kaufman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tAck

@ovitrif ovitrif merged commit 6be2092 into master Jan 19, 2026
43 of 51 checks passed
@ovitrif ovitrif deleted the feat/format-money-value branch January 19, 2026 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ben-kaufman ben-kaufman ben-kaufman approved these changes

@jvsena42 jvsena42 jvsena42 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ovitrif @ben-kaufman @jvsena42