fix: unified invoice validation with zero on-chain balance #672
+17
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes unified invoice validation to accept Lightning payment when on-chain balance is zero.
Description
When typing or pasting a unified invoice (BIP21 with embedded Lightning), the validation incorrectly rejected it if on-chain balance was zero, even when the user had sufficient Lightning balance. The fix adds unified invoice detection to
validateOnChainAddress(), mirroring the existing logic inonScanOnchain().Preview
VIDEO_1
QA Notes
1. Unified invoice with Lightning balance only
?lightning=param)2. Regression - Pure on-chain address
3. Regression - Scan flow