-
Notifications
You must be signed in to change notification settings - Fork 1
fix(notifications): handling for payments and channel opening #306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR improves notification handling for Lightning payments and channel operations by ensuring proper LSP peer connections and payment validation. The changes fix potential issues where notifications could be shown for incorrect payments or channels could fail to open due to missing peer connections.
Key Changes:
- Add LSP peer connection validation before channel opening operations
- Implement payment hash matching to prevent wrong payment notifications
- Add activity tracking and UI sheet display for CJIT payments
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| BitkitNotification/NotificationService.swift | Adds peer connection handling, payment hash validation, CJIT activity tracking, and cleans up unused code |
| Bitkit/ViewModels/AppViewModel.swift | Adds receivedTx sheet display for CJIT payments |
7b97bfc to
cdb87dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
value displayed on CJIT sheet matches the outbound ✅
couldn't test the notification
Description
.orderPaymentConfirmed.paymentReceivedto prevent wrong payment notifications.receivedTxsheet for CJIT payments