Skip to content

Conversation

@pwltr
Copy link
Contributor

@pwltr pwltr commented Jan 7, 2026

Description

  • Ensure LSP peer connection before opening channel in .orderPaymentConfirmed
  • Match payment hash in .paymentReceived to prevent wrong payment notifications
  • Add activity item and .receivedTx sheet for CJIT payments
  • Clean up commented code and unused variables

@jvsena42 jvsena42 requested a review from Copilot January 7, 2026 18:17
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves notification handling for Lightning payments and channel operations by ensuring proper LSP peer connections and payment validation. The changes fix potential issues where notifications could be shown for incorrect payments or channels could fail to open due to missing peer connections.

Key Changes:

  • Add LSP peer connection validation before channel opening operations
  • Implement payment hash matching to prevent wrong payment notifications
  • Add activity tracking and UI sheet display for CJIT payments

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.

File Description
BitkitNotification/NotificationService.swift Adds peer connection handling, payment hash validation, CJIT activity tracking, and cleans up unused code
Bitkit/ViewModels/AppViewModel.swift Adds receivedTx sheet display for CJIT payments

@pwltr pwltr force-pushed the fix/notifications branch from 7b97bfc to cdb87dc Compare January 7, 2026 21:25
@pwltr pwltr requested a review from jvsena42 January 7, 2026 21:26
Copy link
Member

@jvsena42 jvsena42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

value displayed on CJIT sheet matches the outbound ✅
couldn't test the notification

@jvsena42 jvsena42 merged commit a1a1e37 into master Jan 8, 2026
15 checks passed
@jvsena42 jvsena42 deleted the fix/notifications branch January 8, 2026 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants