Skip to content

Conversation

@pwltr
Copy link
Collaborator

@pwltr pwltr commented Mar 19, 2025

Description

Update beignet and react-native-electrum-client to avoid crash when connecting to Electrum server using older protocol version.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (improving code without creating new functionality)

Tests

  • Detox test
  • Unit test
  • No test

QA Notes

  1. Switch to mainnet
  2. Connect to VPS.hsmiths.com:50002
  3. Restart app
  4. Shouldn't crash

@pwltr pwltr requested a review from coreyphillips March 19, 2025 22:12
@socket-security
Copy link

Updated dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher
npm/beignet@0.0.520.0.54 None 0 9.47 MB pwltr
npm/rn-electrum-client@0.0.210.0.22 None 0 68.4 kB pwltr

View full report↗︎

@Jasonvdb Jasonvdb merged commit 14c9664 into master Mar 20, 2025
7 checks passed
@pwltr pwltr deleted the fix/electrum-crash branch March 20, 2025 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants