Skip to content

Conversation

@catch-21
Copy link
Collaborator

@catch-21 catch-21 commented Sep 3, 2025

Description

Bump build and version for android only to resolve incorrect bundle released for android v1.1.4.

Linked Issues/Tasks

Add any links to GitHub issues or Asana tasks that are relevant to this pull request.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (improving code without creating new functionality)

Tests

  • Detox test
  • Unit test
  • No test

Screenshot / Video

Insert relevant screenshot / recording

QA Notes

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce during the Bitkit testing session. You can also leave a video of the PR in action.

@socket-security
Copy link

socket-security bot commented Sep 3, 2025

No dependency changes detected. Learn more about Socket for GitHub.

👍 No dependency changes detected in pull request

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR bumps the version to 1.1.5 specifically for Android to resolve an incorrect bundle that was released for Android v1.1.4, while maintaining iOS at v1.1.4.

  • Updates package.json version from 1.1.3 to 1.1.5
  • Increments Android version code from 158 to 160 and version name to 1.1.5
  • Updates iOS build number and marketing version to align with v1.1.4

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
package.json Updates main version from 1.1.3 to 1.1.5
ios/bitkit.xcodeproj/project.pbxproj Increments iOS build number to 159 and marketing version to 1.1.4
android/app/build.gradle Updates Android version code to 160 and version name to 1.1.5

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

"name": "bitkit",
"author": "Synonym",
"version": "1.1.4",
"version": "1.1.5",
Copy link

Copilot AI Sep 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The package.json version is set to 1.1.5 while iOS is being released as 1.1.4. This version inconsistency between the main package version and platform-specific versions could cause confusion in dependency management and release tracking.

Suggested change
"version": "1.1.5",
"version": "1.1.4",

Copilot uses AI. Check for mistakes.
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The plan is to only release this one for android and align the versions again with iOS for the next release (v1.1.6)

@catch-21 catch-21 merged commit 3662576 into master Sep 5, 2025
7 checks passed
@catch-21 catch-21 deleted the release-v1.1.5 branch September 5, 2025 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants