Skip to content

Fix/rn 0.78 compatibility #295

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jvsena42 merged 32 commits into from
Nov 18, 2025
Merged

Fix/rn 0.78 compatibility #295

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
32 commits
Select commit Hold shift + click to select a range
a129cb4
fix: add react context getter to LdkEventEmitter
jvsena42 Nov 17, 2025
43e58e2
fix: ReactContext doesn't have a runOnUiThread() method in React Nati…
jvsena42 Nov 17, 2025
b6dc606
chore: version number
jvsena42 Nov 17, 2025
27ae87e
fix: lint missing comma
jvsena42 Nov 17, 2025
9d515df
fix: implement docker compose cli, use direct homebrew instalation in…
jvsena42 Nov 17, 2025
9e36e37
fix: Exclude nested node_modules in the lib package to avoid bundling…
jvsena42 Nov 17, 2025
9cc8fe1
chore: update mocha cli
jvsena42 Nov 17, 2025
c61f6c3
fix: timeout
jvsena42 Nov 17, 2025
2029374
fix: update yarn
jvsena42 Nov 17, 2025
8b5d49d
fix: update iOS deployment target to 13.0 and fix boost checksum issue
jvsena42 Nov 17, 2025
f546797
fix: unit tests
jvsena42 Nov 17, 2025
b63a95d
fix: lint
jvsena42 Nov 17, 2025
aad7436
fix: boost checksum issue before CocoaPods loads the podspec
jvsena42 Nov 17, 2025
2075371
fix: remove sha checksum temporarilly
jvsena42 Nov 17, 2025
c75913c
chore: cancel in porgress run
jvsena42 Nov 17, 2025
5e1aacd
fix: set COCOAPODS_DISABLE_CHECKSUM env var for iOS workflows
jvsena42 Nov 17, 2025
b38a021
fix: proactively clean CocoaPods cache to prevent boost archive corru…
jvsena42 Nov 17, 2025
5cf5bd8
fix:boost download issue by using SourceForge mirror instead of JFrog
jvsena42 Nov 17, 2025
2252f27
chore: chage ios device to iPhone 15
jvsena42 Nov 17, 2025
42ebec5
fix: Setup chai-as-promised for mocha tests
jvsena42 Nov 17, 2025
e9b5db8
chore: update detox
jvsena42 Nov 17, 2025
28ac6ee
fix: mocha tests
jvsena42 Nov 17, 2025
8b02435
fix: detox version
jvsena42 Nov 17, 2025
2cdba31
fix: context.js tried to read docker/lnd/admin.macaroon before LND fi…
jvsena42 Nov 18, 2025
48bca56
chore: lint
jvsena42 Nov 18, 2025
0a82ef7
fix: Only output the encoded context to stdout
jvsena42 Nov 18, 2025
512875e
chore: restore test code to match master branch
jvsena42 Nov 18, 2025
5ab9d6f
chore: revert test code
jvsena42 Nov 18, 2025
258adf5
chore: revert test
jvsena42 Nov 18, 2025
5c0c1df
chore: lint
jvsena42 Nov 18, 2025
af90816
chore: restore test code
jvsena42 Nov 18, 2025
dc0f808
chore: restore test files
jvsena42 Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,6 @@ example/.watchman*
# docker
example/docker/lnd/
example/docker/clightning/

#AI
CLAUDE.md
4 changes: 4 additions & 0 deletions example/metro.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,10 @@ const config = {
vm: path.resolve(__dirname, 'node_modules/vm-browserify/'),
process: path.resolve(__dirname, 'node_modules/process/'),
},
blockList: [
// Exclude nested node_modules in the lib package to avoid bundling conflicts
/node_modules\/@synonymdev\/react-native-ldk\/node_modules\/.*/,
],
},
};

Expand Down
2 changes: 1 addition & 1 deletion example/tests/eclair.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ describe('Eclair', function () {
channelCloseMinimum: 5,
outputSpendingFee: 10,
urgentOnChainSweep: 30,
maximumFeeEstimate: 30
maximumFeeEstimate: 30,
});
},
});
Expand Down
4 changes: 4 additions & 0 deletions lib/android/src/main/java/com/reactnativeldk/LdkModule.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1730,6 +1730,10 @@ object LdkEventEmitter {
this.reactContext = reactContext
}

fun getReactContext(): ReactContext? {
return this.reactContext
}

fun send(eventType: EventTypes, body: Any) {
if (this.reactContext === null) {
return
Expand Down
4 changes: 2 additions & 2 deletions lib/android/src/main/java/com/reactnativeldk/classes/LdkPersister.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ class LdkPersister {
file.writeBytes(serialized)

// Update chain monitor on main thread
LdkModule.reactContext?.runOnUiThread {
LdkEventEmitter.getReactContext()?.runOnUiQueueThread {
Copy link
Contributor

@ovitrif ovitrif Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this change doesn't make a lot of sense to me. Why would we change what was already there?!

Copy link
Member Author

@jvsena42 jvsena42 Nov 18, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The method runOnUiThread doesn't exist on ReactContext class, that is why I assumed it was removed
https://github.com/facebook/react-native/blob/0ee4a2d01a7abac197851d648260a7a34648c59d/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/ReactContext.java#L369

Here you can see that ReactContextBaseJavaModule is a child of BaseJavaModule
https://github.com/facebook/react-native/blob/main/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/ReactContextBaseJavaModule.kt

And here you can see that the mReactApplicationContext is a private property
https://github.com/facebook/react-native/blob/main/packages/react-native/ReactAndroid/src/main/java/com/facebook/react/bridge/BaseJavaModule.java

Copy link
Member Author

@jvsena42 jvsena42 Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the ReactNative version of the project was updated

val res = LdkModule.chainMonitor?.channel_monitor_updated(channelFundingOutpoint, data._latest_update_id)
if (res == null || !res.is_ok) {
LdkEventEmitter.send(EventTypes.native_log, "Failed to update chain monitor with persisted channel (${channelId})")
Expand Down Expand Up @@ -75,7 +75,7 @@ class LdkPersister {
}

//Update chain monitor with successful persist on main thread
LdkModule.reactContext?.runOnUiThread {
LdkEventEmitter.getReactContext()?.runOnUiQueueThread {
Copy link
Contributor

@ovitrif ovitrif Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this change doesn't make a lot of sense to me. Why would we change what was already there?!

val res = LdkModule.chainMonitor?.channel_monitor_updated(channelFundingOutpoint, data._latest_update_id)
if (res == null || !res.is_ok) {
LdkEventEmitter.send(EventTypes.native_log, "Failed to update chain monitor with persisted channel (${channelId})")
Expand Down
2 changes: 1 addition & 1 deletion lib/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "@synonymdev/react-native-ldk",
"title": "React Native LDK",
"version": "0.0.161",
"version": "0.0.162",
"description": "React Native wrapper for LDK",
"main": "./dist/index.js",
"types": "./dist/index.d.ts",
Expand Down
Loading