Added mem-dbg across crate as optional featuew#20
Open
LucaCappelletti94 wants to merge 5 commits intotabac:masterfrom
Open
Added mem-dbg across crate as optional featuew#20LucaCappelletti94 wants to merge 5 commits intotabac:masterfrom
LucaCappelletti94 wants to merge 5 commits intotabac:masterfrom
Conversation
Author
Owner
|
@LucaCappelletti94 thanks a lot for the PR. I will look into it as soon as possible (probably ~end-of-month). |
Owner
|
@LucaCappelletti94 PR LGTM. Three questions I have:
Thanks again for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mem-dbg is a crate that allows to compute the size of a struct. I have added the derives through the crate as an optional feature, so as to use it to compare this implementation with others easily.
Cheers!