Conversation
WalkthroughThe changes involve updating the lightningcss dependency across the project configuration. The patch entry for lightningcss@1.30.2 is removed from the pnpm patched dependencies in package.json. Simultaneously, the pnpm-workspace.yaml catalog is updated to bump the lightningcss package family from version 1.30.2 to 1.31.0, including all platform-specific variants. The 🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Nice to see there's finally a fix for this. Hoping the team can get this merged soon 🤞 Been waiting for this so long! |
|
This would be really nice to have merged. Currently forced to use webpack for my Next.js project to use custom scroll-state containers. |
This PR bumps a bunch of dependencies. This also moves a few dependencies that we use in multiple packages to the pnpm catalog. Closes: #19603, #19604, #19576, #19575, #19573, #19565, #19547, #19546, #19545, #19609, #19581, #19620, #19619 - #19603 - #19604 - #19576 - #19575 - #19573 - #19565 - #19547 - #19546 - #19545 - #19609 - #19581 - #19620 - #19620 - #19619 ## Test Plan All tests in CI should still pass. [ci-all]
|
Hey! Appreciate the PR. There were a few changes required for handling the Lightning CSS bump. They don't normalize whitespace anymore in custom properties to follow the spec more so that resulted in some failing tests. Tackled this in a bigger #19608 PR. Thanks again! |
5 participants
Summary
Upgrade lightningcss to 1.31.0, mainly to add support for scroll-state container queries
Test plan
I ran
pnpm testand got 25 failed tests, that's 3 more than there were with lightningcss 1.30.2 Not sure how to proceed.