Merged
Conversation
w4terlaw
force-pushed
the
fix/90-regression-queue-function
branch
from
fa7800d to
5b79035
Compare
Contributor
|
Thx @w4terlaw . @Lancetnik , FYI, this fixes regression #90 . It may be good to add a test for functions and generators, not just messages to avoid future regressions. |
Contributor
Author
|
Yep, I’ll add tests. And yeah, good to check that labels keep their type.
|
Collaborator
|
@yann-combarnous sorry, I was sure, that we have such tests |
Lancetnik
requested changes
May 25, 2025
Collaborator
Lancetnik
left a comment
Lancetnik
left a comment
There was a problem hiding this comment.
Can you please add a tests for generators as a message, please?
Contributor
Author
|
yes
|
Lancetnik
approved these changes
Jun 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.