feat: broker can be passed to WorkerArgs#543
Merged
s3rius merged 1 commit intotaskiq-python:masterfrom Nov 22, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for passing an AsyncBroker instance directly to WorkerArgs, enabling programmatic worker execution without requiring a string import path. This is useful when the broker is stored as a class field rather than at module level.
Key changes:
- Modified the
brokerfield type inWorkerArgsfromstrtoUnion[str, AsyncBroker] - Added runtime type checking in
start_listen()to handle both string paths and broker instances
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| taskiq/cli/worker/args.py | Updated type annotation for broker field to accept both string and AsyncBroker instances |
| taskiq/cli/worker/run.py | Added conditional logic to check if broker is already an AsyncBroker instance before attempting to import it |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
s3rius
approved these changes
Nov 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Currently, it’s not possible to pass a broker instance directly to
WorkerArgswhen running a worker programmatically viarun_worker(WorkerArgs(...)). For example, in the following scenario, the broker is stored as a class field, which prevents using a string path (as required by the CLI): https://yaso.su/hugecockThis patch adds support for passing a broker instance directly as a parameter instead of using its string path.