Skip to content

Update Maven configuration for central publishing #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tcheeric merged 1 commit into from
Oct 14, 2025
Merged

Update Maven configuration for central publishing #489

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion scripts/release.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,12 @@ cmd_publish() {
$no_docker && mvn_args=(-q -DnoDocker=true -P "$profile" deploy)
$skip_tests && mvn_args=(-q -DskipTests -P "$profile" deploy)
if $no_docker && $skip_tests; then mvn_args=(-q -DskipTests -DnoDocker=true -P "$profile" deploy); fi
run_cmd mvn $MVN_SETTINGS_OPTS "${mvn_args[@]}"
# For Central publishing, prefer the settings provided by actions/setup-java (no -s override)
if [[ "$profile" == "release-central" ]]; then
run_cmd mvn "${mvn_args[@]}"
else
run_cmd mvn $MVN_SETTINGS_OPTS "${mvn_args[@]}"
Comment on lines +136 to +140
Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot Oct 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Restore fallback to project settings for local central publish

The new branch that skips MVN_SETTINGS_OPTS for the release-central profile causes scripts/release.sh publish --repo central to ignore .mvn/settings.xml. That file now contains the repository and server credentials driven by CENTRAL_USERNAME/CENTRAL_PASSWORD, so on a developer machine (where actions/setup-java is not writing ~/.m2/settings.xml) the command runs without any server configuration and the deploy will fail with a 401/missing repository. Consider only skipping -s .mvn/settings.xml when a CI‑provided settings file is present, otherwise retain the previous behaviour so local releases continue to work.

Useful? React with 👍 / 👎.

fi
}

cmd_next_snapshot() {
Expand Down
Loading