Update font-family CSS property in cyberpunk and wireframe themes#97
Update font-family CSS property in cyberpunk and wireframe themes#97techniq merged 5 commits intotechniq:nextfrom
Conversation
🦋 Changeset detectedLatest commit: 8af5e3c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@justlilith thanks! care to add a changeset with |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
@layerstack/svelte-actions
@layerstack/svelte-state
@layerstack/svelte-stores
@layerstack/svelte-table
@layerstack/tailwind
@layerstack/utils
commit: |
|
@justlilith we could also remove the |
|
@techniq good point; I removed the font family altogether now (and added a changeset; I hope I did so correctly, as it's my first time) |
Looks good! Thanks for the PR! |
| [data-theme="cyberpunk"] { | ||
| color-scheme: light; | ||
| fontfamily: | ||
| font-family: |
There was a problem hiding this comment.
Actually, we should remove them from here as well
|
At some point we might need to update the CLI scripts that generates these from skeleton/daisy UI source, but it's currently only ran on demand and TBH I'm not sure if/when we'll regenerate again as they don't change often (or need to be 100% in sync). |
|
Just deployed @layerstack/tailwind@2.0.0-next.22. Thanks again! |
The cyberpunk and wireframe themes were generated with a slightly invalid property,
fontfamily, rather thanfont-family. This PR fixes the property to prevent downstream build warnings concerning unsupported/invalid CSS properties.It seems to be an issue stemming from Daisy removing the font families from those two themes upstream (https://github.com/saadeghi/daisyui/blob/de213728084450b81d683cb01795205a3b518941/packages/docs/src/routes/(routes)/docs/v5/%2Bpage.md?plain=1#L796).