-
-
Notifications
You must be signed in to change notification settings - Fork 1
⬆️ widen Python support #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughExpands supported Python versions to 3.8–3.14 across CI workflow, tox, and packaging metadata; updates docs to state 3.8+ support; adjusts dev dependency versions for compatibility; and adds postponed evaluation of type annotations in two source modules. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #29 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 16 16
Lines 1148 1150 +2
=========================================
+ Hits 1148 1150 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
.github/workflows/test.yml (1)
45-58: Remove the 3.14 job until tooling actually ships it.GitHub’s
actions/setup-python@v6cannot install Python 3.14 today, so this matrix entry will make every run fail before tests even start. Please drop (or gate) the 3.14 row until the runtime exists.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (7)
.github/workflows/test.yml(2 hunks)CONTRIBUTING.md(1 hunks)pyproject.toml(5 hunks)requirements_dev.txt(1 hunks)src/qs_codec/decode.py(1 hunks)src/qs_codec/models/weak_wrapper.py(1 hunks)tox.ini(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Codacy Static Code Analysis
This pull request adds support for Python 3.8 and 3.14, expanding the range of supported Python versions. It also updates documentation and configuration files to reflect these changes, and lowers the minimum required versions for several development dependencies to improve compatibility. Additionally,
from __future__ import annotationsis added to two modules for forward compatibility.Python version support:
.github/workflows/test.yml),tox.ini, andpyproject.tomlclassifiers and settings. [1] [2] [3] [4] [5]CONTRIBUTING.mdandpyproject.toml. [1] [2] [3]Development dependencies:
pytest,pytest-cov, andmypyare lowered in bothpyproject.tomlandrequirements_dev.txtto improve compatibility with older Python versions. [1] [2]Codebase modernization:
from __future__ import annotationstosrc/qs_codec/decode.pyandsrc/qs_codec/models/weak_wrapper.pyfor improved forward compatibility and type hinting. [1] [2]Summary by CodeRabbit
Documentation
Tests
Chores