Skip to content

Move test check invocation under the umbrella of test invocation #4453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
happz wants to merge 1 commit into
base: test-invocation-environment-moved
Choose a base branch
from
Open

Move test check invocation under the umbrella of test invocation #4453

happz wants to merge 1 commit into from
+35 −79

Conversation

@happz
Copy link
Contributor

@happz happz commented Dec 29, 2025

Pull Request Checklist

  • implement the feature

@happz happz added code | style Code style changes not affecting functionality code | no functional change "No Functional Change" intended. Patch should not change tmt's behavior in any way. ci | full test Pull request is ready for the full test execution labels Dec 29, 2025
@happz happz added this to planning Dec 29, 2025
@github-project-automation github-project-automation bot moved this to backlog in planning Dec 29, 2025
@happz happz moved this from backlog to implement in planning Dec 29, 2025
@happz happz mentioned this pull request Dec 29, 2025
Draft
16 tasks
@happz happz force-pushed the test-invocation-environment-moved branch from 9b129e8 to 6d96626 Compare December 29, 2025 20:40
@happz happz force-pushed the test-invocation-checks-moved branch 2 times, most recently from 8b5a98b to d291881 Compare December 29, 2025 21:19
@happz happz force-pushed the test-invocation-environment-moved branch from 35e6411 to 1263261 Compare January 5, 2026 14:26
@happz happz force-pushed the test-invocation-environment-moved branch from 1263261 to f0f4627 Compare January 8, 2026 09:55
@happz
Move test check invocation under the umbrella of test invocation
bcd8c01 
After moving the environment, they can be simplified a lot, fixing the
use of the right logger in the process. Since the test invocation class
is the owner of "invoke me a test, please" task, and invoking test
checks is part of this task (a test result without check results is
incomplete), it's the natural place to own this piece of code.
@happz happz force-pushed the test-invocation-checks-moved branch from d291881 to bcd8c01 Compare January 8, 2026 09:56
@psss psss added this to the 1.65 milestone Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AthreyVinay AthreyVinay AthreyVinay approved these changes

@vaibhavdaren vaibhavdaren vaibhavdaren approved these changes

@LecrisUT LecrisUT LecrisUT approved these changes

Assignees

No one assigned

Labels

ci | full test Pull request is ready for the full test execution code | no functional change "No Functional Change" intended. Patch should not change tmt's behavior in any way. code | style Code style changes not affecting functionality

Projects

planning
Status: implement

Milestone

1.65

Development

Successfully merging this pull request may close these issues.

6 participants

@happz @AthreyVinay @vaibhavdaren @LecrisUT @psss