Use io.ReadFull to read the bundle content #2432
Conversation
The io.Reader documentation says: > Read reads up to len(p) bytes into p. It returns the number of bytes > read (0 <= n <= len(p)) and any error encountered. ... If some data is > available but not len(p) bytes, Read conventionally returns what is > available instead of waiting for more. Read is not guaranteed to fill the data argument. Use io.ReadFull to fill the buffer. In some cases (a relatively big bundle), the bundle content was not completely read and it would fail to parse. Using `io.ReadFull` fixes the issue. *Note:* because bundles are cached, one will need to clean their cache bundle (`~/.tekton/bundles`) to make sure it re-fetches correct content. Signed-off-by: Vincent Demeester <vdemeest@redhat.com>
|
@vdemeester: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
tekton-robot
added
the
do-not-merge/release-note-label-needed
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
tekton-robot
added
the
size/XS
2 participants
The io.Reader documentation says:
Read is not guaranteed to fill the data argument. Use io.ReadFull to
fill the buffer.
In some cases (a relatively big bundle), the bundle content was not
completely read and it would fail to parse. Using
io.ReadFullfixesthe issue.
Note: because bundles are cached, one will need to clean their cache
bundle (
~/.tekton/bundles) to make sure it re-fetches correctcontent.
Signed-off-by: Vincent Demeester vdemeest@redhat.com