Enhance ShutdownWorkerRequest and poll calls with worker_instance_key #686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cretz
reviewed
Dec 9, 2025
cretz
reviewed
Dec 10, 2025
yuandrew
changed the title
yuandrew
changed the title
cretz
approved these changes
Jan 23, 2026
rkannan82
reviewed
Jan 23, 2026
rkannan82
left a comment
rkannan82
left a comment
There was a problem hiding this comment.
LGTM. Do we need to add this to PollNexusTaskQueueRequest as well? Not specifically for the server initiated shutdown.
dnr
approved these changes
Jan 23, 2026
Contributor
dnr
left a comment
dnr
left a comment
There was a problem hiding this comment.
update PR description to remove/rewrite
(This also requires all poll requests to contain the Worker Instance Key, can be added in a future PR)
since it's here now
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
worker_instance_keyfield toShutdownWorkerRequest, as well as all other poll calls.ShutdownWorkerRequest.sticky_task_queuesaying it may be blank, now that we've expanded the scope of whenShutdownWorkerRequestis called.task_queueandtask_queue_kindtoShutdownWorkerRequestWhy?
ShutdownWorker was changed to always be sent by SDK (temporalio/sdk-core#1082), so sticky queue name is now optional. This plus the new heartbeat info we send on shutdown means Server will now have a more accurate map of which workers are shutting down.
Adding task queue and task_queue_kind should also allow us to fix a lost task issue, where there is a race when the SDK cancels an outstanding poll rpc and the server decides to send a task to that poller.
Technically some of this info exists in the worker heartbeat part of the message, but it needs to be lifted to its own field due to the scenario where worker heartbeating is disabled.
Breaking changes
N/A I think, just adding new fields
Server PR