-
Notifications
You must be signed in to change notification settings - Fork 189
workflowcheck - initial support for Java static analyzer #2356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cretz
wants to merge
2
commits into
temporalio:master
Choose a base branch
from
cretz:workflowcheck
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| plugins { | ||
| id 'application' | ||
| id 'com.gradleup.shadow' version '8.3.3' | ||
| } | ||
|
|
||
| description = 'Temporal Java WorkflowCheck Static Analyzer' | ||
|
|
||
| dependencies { | ||
| implementation 'org.ow2.asm:asm:9.6' | ||
| compileOnly 'com.google.code.findbugs:jsr305:3.0.2' | ||
| testImplementation project(":temporal-sdk") | ||
| testImplementation "junit:junit:${junitVersion}" | ||
| // Only for testing external-JAR-based bad calls | ||
| testImplementation "com.google.guava:guava:$guavaVersion" | ||
| } | ||
|
|
||
| application { | ||
| mainClass = 'io.temporal.workflowcheck.Main' | ||
| } | ||
|
|
||
| // Need all-in-one JAR | ||
| shadowJar { | ||
| relocate 'org.objectweb.asm', 'io.temporal.workflowcheck.shaded.org.objectweb.asm' | ||
| } | ||
| build.dependsOn shadowJar | ||
|
|
||
| // Access Java test source as resource | ||
| tasks.register('copyJavaSourcesToResources') { | ||
| doLast { | ||
| copy { | ||
| from('src/test/java') { | ||
| include '**/*.*' | ||
| } | ||
| into 'build/resources/test' | ||
| } | ||
| } | ||
| } | ||
| processTestResources.dependsOn copyJavaSourcesToResources | ||
|
|
||
| spotless { | ||
| java { | ||
| toggleOffOn() | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,3 @@ | ||
| gradle/build | ||
| gradle-multi-project/project-app/build | ||
| gradle-multi-project/project-workflows/build |
18 changes: 18 additions & 0 deletions
18
temporal-workflowcheck/samples/gradle-multi-project/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| # Temporal Workflow Check for Java - Gradle Sample | ||
|
|
||
| This sample shows how to incorporate `workflowcheck` into a Gradle build that has multiple projects. Currently there are | ||
| no published releases, so this example includes the primary build in the [settings.gradle](settings.gradle) file. But | ||
| users may just want to reference a published JAR when it is available. | ||
|
|
||
| To run: | ||
|
|
||
| gradlew check | ||
|
|
||
| This will output something like: | ||
|
|
||
| ``` | ||
| Analyzing classpath for classes with workflow methods... | ||
| Found 1 class(es) with workflow methods | ||
| Workflow method io.temporal.workflowcheck.sample.gradlemulti.workflows.MyWorkflowImpl.errorAtNight() (declared on io.temporal.workflowcheck.sample.gradlemulti.workflows.MyWorkflow) has 1 invalid member access: | ||
| MyWorkflowImpl.java:10 invokes java.time.LocalTime.now() which is configured as invalid | ||
| ``` |
9 changes: 9 additions & 0 deletions
9
temporal-workflowcheck/samples/gradle-multi-project/build.gradle
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| plugins { | ||
| id 'java' | ||
| } | ||
|
|
||
| allprojects { | ||
| repositories { | ||
| mavenCentral() | ||
| } | ||
| } |
Binary file added
BIN
+59.3 KB
temporal-workflowcheck/samples/gradle-multi-project/gradle/wrapper/gradle-wrapper.jar
Binary file not shown.
6 changes: 6 additions & 0 deletions
6
temporal-workflowcheck/samples/gradle-multi-project/gradle/wrapper/gradle-wrapper.properties
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| #Sun Dec 24 20:45:25 CST 2023 | ||
| distributionBase=GRADLE_USER_HOME | ||
| distributionPath=wrapper/dists | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-8.4-bin.zip | ||
| zipStoreBase=GRADLE_USER_HOME | ||
| zipStorePath=wrapper/dists |
234 changes: 234 additions & 0 deletions
234
temporal-workflowcheck/samples/gradle-multi-project/gradlew
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unlike the
-shadedproject, we just need the-all.jarthis generates, and we only have one real dependency anyways