Skip to content

Add sleep method with options for timer #2764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kevinrobayna wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add sleep method with options for timer #2764

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...l-sdk/src/main/java/io/temporal/common/interceptors/WorkflowOutboundCallsInterceptor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -738,6 +738,8 @@ public DynamicUpdateHandler getHandler() {

void sleep(Duration duration);

void sleep(Duration duration, TimerOptions options);

boolean await(Duration timeout, String reason, Supplier<Boolean> unblockCondition);

void await(String reason, Supplier<Boolean> unblockCondition);
Expand Down
5 changes: 5 additions & 0 deletions ...k/src/main/java/io/temporal/common/interceptors/WorkflowOutboundCallsInterceptorBase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,11 @@ public void sleep(Duration duration) {
next.sleep(duration);
}

@Override
public void sleep(Duration duration, TimerOptions options) {
next.sleep(duration, options);
}

@Override
public boolean await(Duration timeout, String reason, Supplier<Boolean> unblockCondition) {
return next.await(timeout, reason, unblockCondition);
Expand Down
5 changes: 5 additions & 0 deletions temporal-sdk/src/main/java/io/temporal/internal/sync/SyncWorkflowContext.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1315,6 +1315,11 @@ public void sleep(Duration duration) {
newTimer(duration).get();
}

@Override
public void sleep(Duration duration, TimerOptions options) {
newTimer(duration, options).get();
}

@Override
public boolean await(Duration timeout, String reason, Supplier<Boolean> unblockCondition) {
Promise<Void> timer = newTimer(timeout);
Expand Down
5 changes: 5 additions & 0 deletions temporal-testing/src/main/java/io/temporal/testing/TestActivityEnvironmentInternal.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,6 +384,11 @@ public void sleep(Duration duration) {
throw new UnsupportedOperationException("not implemented");
}

@Override
public void sleep(Duration duration, TimerOptions options) {
throw new UnsupportedOperationException("not implemented");
}

@Override
public boolean await(Duration timeout, String reason, Supplier<Boolean> unblockCondition) {
throw new UnsupportedOperationException("not implemented");
Expand Down
8 changes: 8 additions & 0 deletions temporal-testing/src/main/java/io/temporal/testing/internal/TracingWorkerInterceptor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,14 @@ public void sleep(Duration duration) {
next.sleep(duration);
}

@Override
public void sleep(Duration duration, TimerOptions options) {
if (!WorkflowUnsafe.isReplaying()) {
trace.add("sleep " + duration);
}
next.sleep(duration, options);
}

@Override
public boolean await(Duration timeout, String reason, Supplier<Boolean> unblockCondition) {
if (!WorkflowUnsafe.isReplaying()) {
Expand Down