Add method for acquiring application error details with a type hint #1278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
THardy98
reviewed
Jan 15, 2026
THardy98
approved these changes
Jan 20, 2026
cretz
reviewed
Jan 21, 2026
| """User-defined details on the error.""" | ||
| return self.details_with_type_hints() | ||
|
|
||
| def details_with_type_hints( |
Member
There was a problem hiding this comment.
Hrmm, I can't find a similar comment I made for this elsewhere, but basically I think we should:
- Deprecate the
detailsproperty - Add a
details_len()method - Add a
get_detail/detailmethod here that accepts kwargs index (default 0) and type hint (defaultAny)- If details is not
Nonethen this was user created and type must be a supertype of what is in details at that index, then return it - If details is
Nonethen this was created with payloads and_payloadsshould not beNoneand you can perform conversion on the detail at that index (or fail w/ index out of bound)
- If details is not
- Do the same for
activity.Info.heartbeat_details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was changed
Add method for acquiring application error details with a type hint
Why?
Checklist
Closes [Bug] Add ability to obtain
ApplicationErrordetails with type hint #1262How was this tested: