-
Notifications
You must be signed in to change notification settings - Fork 125
Environment Colors #3020
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Alex-Tideman
wants to merge
8
commits into
main
Choose a base branch
from
env-config-ui
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Environment Colors #3020
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| !isCloud && environmentName && environmentName.trim().length > 0, | ||
| ); | ||
| </script> | ||
|
|
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ Argument of type '{ accesskey?: string | null | undefined; autocapitalize?: "on" | "off" | "none" | "characters" | "sentences" | "words" | null | undefined; autofocus?: boolean | null | undefined; class: ClassValue | null; ... 426 more ...; onfullscreenerrorcapture?: EventHandler<...> | ... 1 more ... | undefined; }' is not assignable to parameter of type 'HTMLProps<"nav", HTMLAttributes>'.
| @@ -0,0 +1,6 @@ | |||
| export const setValidEnvironmentName = (name: string | undefined): string => { | |||
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
⚠️ 'name' is possibly 'undefined'.
Contributor
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description & motivation 💭
Allow self-hosted users to set an environment name of development/test/staging to very easily distinguish the Temporal Web UI when multiple environments are used. It can be frustrating to navigate to multiple tabs with different environments and quickly understanding which one you are looking at. If no environment name is set, it will default to the black background.
This also includes refactoring our main layout to use Svelte5.
Screenshots (if applicable) 📸
Design Considerations 🎨
Testing 🧪
How was this tested 👻
Steps for others to test: 🚶🏽♂️🚶🏽♀️
Checklists
Draft Checklist
Merge Checklist
Issue(s) closed
Docs
Any docs updates needed?