Event History Sparkle #3049

Alex-Tideman · 2025-12-04T18:08:42Z

Description & motivation 💭

Screenshots (if applicable) 📸

Design Considerations 🎨

Testing 🧪

How was this tested 👻

Manual testing
E2E tests added
Unit tests added

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

Checklists

Draft Checklist

Merge Checklist

Issue(s) closed

Docs

Any docs updates needed?

vercel · 2025-12-04T18:08:47Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Review	Updated (UTC)
holocene	Ready	Preview, Comment	Dec 15, 2025 3:44pm

Alex-Tideman · 2025-12-04T18:14:47Z

@claude review this for bugs/mistakes

claude · 2025-12-04T18:15:03Z

Claude finished @Alex-Tideman's task —— View job

Code Review Complete ✅

I've reviewed this PR for bugs and mistakes. Found 2 TypeScript errors and several observations:

🐛 Critical Issues

1. Type Error in `event-card.svelte` (Line 87-107)

The eventCategory CVA variant is missing classifications that exist in the type system.

Problem: The type EventClassification includes "Open", "New", and "Running", but the eventCategory variants only define:

Failed, Canceled, TimedOut, Completed, Terminated, Scheduled, Initiated, Started, Fired, Signaled, CancelRequested, Unspecified

Impact: TypeScript compilation error. Runtime error if an event has classification "Open", "New", or "Running".

Fix: Add missing variants to the CVA definition (see inline comment on the PR).

File: src/lib/components/event/event-card.svelte:87-107

2. Type Error in `schedule-input.svelte`

Missing required prop isRunning when using InputAndResultsPayload component.

Problem: The InputAndResultsPayload component now requires isRunning: boolean (added in this PR), but schedule-input.svelte doesn't pass it.

Impact: TypeScript compilation error. This file isn't in the PR diff but the error was introduced by changes to InputAndResultsPayload in this PR.

Fix: Either include the fix in this PR or create a follow-up. See my separate comment for details.

File: src/lib/components/schedule/schedule-input.svelte:12

⚠️ Observations

1. Potential Logic Issue in `event-details-full.svelte`

Line 64 accesses group.isPending without optional chaining when group could be undefined.

const emptyValue = $derived(
  group.isPending ? 'Results will appear upon completion' : 'null',
);

Should be:

const emptyValue = $derived(
  group?.isPending ? 'Results will appear upon completion' : 'null',
);

File: src/lib/components/event/event-details-full.svelte:64

See inline comment for suggested fix.

2. Unused/Unmodified State Variable

In input-and-results-payload.svelte:18, there's an inline state variable that's never modified:

let inline = $state(false);

This is used in the template but never changes. Consider if this should be:

A reactive variable based on some condition
Just a constant instead of state
Connected to the (now unused) $minimizeEventView store that was removed

File: src/lib/components/workflow/input-and-results-payload.svelte:18

✅ Positive Observations

Svelte 5 patterns: Excellent use of $props(), $derived(), $state(), and $effect() throughout
Type safety: Good use of TypeScript interfaces for Props
Component structure: Clean separation with snippets
Consistent styling: Proper use of Tailwind and CVA
Import order: Follows CLAUDE.md guidelines correctly

📋 Summary

Critical bugs: 2 TypeScript errors blocking the build
Potential issues: 2 observations that could cause problems
Code quality: Generally good, following Svelte 5 and repo patterns well

Recommendation: Fix the 2 TypeScript errors before merging. Run pnpm check to verify all type errors are resolved.

claude · 2025-12-04T18:19:54Z

src/lib/components/event/event-card.svelte

+  const eventCategory = cva(
+    ['flex flex-1 flex-col overflow-hidden rounded-t-lg pb-2'],
+    {
+      variants: {
+        classification: {
+          Failed: 'bg-red-800',
+          Canceled: 'bg-orange-900/80',
+          TimedOut: 'bg-orange-700',
+          Completed: 'bg-green-700',
+          Terminated: 'bg-gray-300',
+          Scheduled: 'bg-orange-900/50',
+          Initiated: 'bg-orange-900/50',
+          Started: 'bg-orange-900/60',
+          Fired: 'bg-orange-900/90',
+          Signaled: 'bg-orange-900/50',
+          CancelRequested: 'bg-orange-900/70',
+          Unspecified: 'bg-orange-900/60',
+        },
+      },
+    },
+  );


Type Error: Missing classifications in CVA variants.

The EventClassification type includes "Open", "New", and "Running" but they're not defined in the variants. This will cause a TypeScript error when these classifications are used.

Add the missing variants:

Open: 'bg-orange-900/50', New: 'bg-orange-900/50', Running: 'bg-orange-900/60',

src/lib/components/event/event-details-full.svelte

claude · 2025-12-04T18:20:12Z

Additional Issue Found (not in this PR's changes):

While running type checking, I found an error in src/lib/components/schedule/schedule-input.svelte that was likely introduced by changes in this PR to InputAndResultsPayload.

The InputAndResultsPayload component now requires an isRunning prop, but schedule-input.svelte doesn't pass it. This should be fixed in a follow-up or included in this PR if you're modifying that file.

Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>

temporal-cicd · 2025-12-15T15:44:39Z

src/lib/models/event-groups/create-event-group.ts

    get finalClassification() {
      return getLastEvent(this).classification;
    },
+    get input() {


⚠️ Property 'input' does not exist on type 'IUserMetadata | IWorkflowExecutionStartedEventAttributes | IWorkflowExecutionCompletedEventAttributes | ... 54 more ... | INexusOperationCancelRequestFailedEventAttributes'.

temporal-cicd · 2025-12-15T15:44:39Z

src/lib/models/event-groups/create-event-group.ts

+    get input() {
+      return this.initialEvent.attributes?.input;
+    },
+    get result() {


⚠️ Property 'result' does not exist on type 'IUserMetadata | IWorkflowExecutionStartedEventAttributes | IWorkflowExecutionCompletedEventAttributes | ... 54 more ... | INexusOperationCancelRequestFailedEventAttributes'.

temporal-cicd · 2025-12-15T15:44:41Z

	Warnings
⚠️	📊 Strict Mode: 19 errors in 2 files (5.7% of 334 total) src/lib/components/lines-and-dots/constants.ts (13) L129:48: Function lacks ending return statement and return type does not include 'undefined'. L145:6: 'group' is possibly 'undefined'. L145:40: 'group' is possibly 'undefined'. L148:43: 'group' is possibly 'undefined'. L150:52: 'group' is possibly 'undefined'. L154:70: 'group' is possibly 'undefined'. L156:52: 'group' is possibly 'undefined'. L158:55: 'group' is possibly 'undefined'. L162:47: Argument of type 'EventGroup \| undefined' is not assignable to parameter of type 'EventGroup'. L163:4: 'group' is possibly 'undefined'. L165:2: 'group' is possibly 'undefined'. L166:9: 'group' is possibly 'undefined'. L189:54: Operator '+' cannot be applied to types 'number \| boolean' and 'number'. src/lib/models/event-groups/create-event-group.ts (6) L93:8: Type '(ILink \| undefined)[]' is not assignable to type 'ILink[]'. L103:43: Property 'input' does not exist on type 'IUserMetadata \| IWorkflowExecutionStartedEventAttributes \| IWorkflowExecutionCompletedEventAttributes \| ... 54 more ... \| INexusOperationCancelRequestFailedEventAttributes'. L106:40: Property 'result' does not exist on type 'IUserMetadata \| IWorkflowExecutionStartedEventAttributes \| IWorkflowExecutionCompletedEventAttributes \| ... 54 more ... \| INexusOperationCancelRequestFailedEventAttributes'. L129:24: 'event.billableActions' is possibly 'undefined'. L136:61: Function lacks ending return statement and return type does not include 'undefined'. L167:3: Function lacks ending return statement and return type does not include 'undefined'.

Generated by 🚫 dangerJS against 1e0cdcc

Alex-Tideman and others added 30 commits October 24, 2025 15:13

WIP purple button timeline

86b5759

Add purple for bg

ce9644b

Move input/result to top of card

21eb11f

Fix pending activities

1ddff20

Lighter purple

fbdaa1e

Fix the hover length, add durations

65ac34c

Add the colors per category

7c91583

Better titles

6f29967

More pretty things

696a65c

More styles

f6f1511

Remove inspect

79d6c2d

Merge branch 'main' into timeline-purple-hover

7c5d88c

Move group title into event-details-full

b632bc4

Styling things

368682f

Fix category check

86628ea

More refactoring, fix task failure card

ee69a2d

Go back to cards

5fdbb20

More leading-3

9a87cc3

Better colors

5ebb5f5

Move things around again

b5a9314

Merge branch 'main' into event-history-colors

2340a1a

Merge branch 'main' into event-history-colors

5097e76

Move timeline to it's own tab, refactor to svelte5, rearrange

8d9fc86

Fix merge conflicts

b075e16

Style updates

db36867

Adjust some colors

231ed7c

WIP toggle timeline and history buttons

86aa56c

Fix merge conflicts?

ca99f90

Fix pending activities to show input. Fix pending nexus operations

1bfe182

Merge branch 'main' into event-history-colors

16f29b7

Alex-Tideman added 2 commits December 4, 2025 10:28

Remove mb

bef2ffa

Remove inspect

88b4242

claude bot reviewed Dec 4, 2025

View reviewed changes

src/lib/components/event/event-details-full.svelte Show resolved Hide resolved

Update src/lib/components/event/event-details-full.svelte

00f326a

Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>

vercel bot deployed to Preview December 4, 2025 18:27 View deployment

Change dot to rect

3be6fa9

vercel bot deployed to Preview December 12, 2025 22:42 View deployment

Alex-Tideman added 4 commits December 12, 2025 17:39

Move things around

570c156

Move things around more

1c5c71d

Make overlay resizeable

a499da9

Merge main

1e0cdcc

vercel bot deployed to Preview December 15, 2025 15:44 View deployment

temporal-cicd bot reviewed Dec 15, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Event History Sparkle #3049

Event History Sparkle #3049

Uh oh!

Alex-Tideman commented Dec 4, 2025

Uh oh!

vercel bot commented Dec 4, 2025 •

edited

Loading

Uh oh!

Alex-Tideman commented Dec 4, 2025

Uh oh!

claude bot commented Dec 4, 2025 •

edited

Loading

Uh oh!

claude bot Dec 4, 2025

Uh oh!

Uh oh!

claude bot commented Dec 4, 2025

Uh oh!

temporal-cicd bot Dec 15, 2025

Uh oh!

temporal-cicd bot Dec 15, 2025

Uh oh!

temporal-cicd bot commented Dec 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Event History Sparkle #3049

Are you sure you want to change the base?

Event History Sparkle #3049

Uh oh!

Conversation

Alex-Tideman commented Dec 4, 2025

Description & motivation 💭

Screenshots (if applicable) 📸

Design Considerations 🎨

Testing 🧪

How was this tested 👻

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

Checklists

Draft Checklist

Merge Checklist

Issue(s) closed

Docs

Any docs updates needed?

Uh oh!

vercel bot commented Dec 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Alex-Tideman commented Dec 4, 2025

Uh oh!

claude bot commented Dec 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Review Complete ✅

🐛 Critical Issues

1. Type Error in event-card.svelte (Line 87-107)

2. Type Error in schedule-input.svelte

⚠️ Observations

1. Potential Logic Issue in event-details-full.svelte

2. Unused/Unmodified State Variable

✅ Positive Observations

📋 Summary

Uh oh!

claude bot Dec 4, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

claude bot commented Dec 4, 2025

Uh oh!

temporal-cicd bot Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

temporal-cicd bot Dec 15, 2025

Choose a reason for hiding this comment

Uh oh!

temporal-cicd bot commented Dec 15, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

vercel bot commented Dec 4, 2025 •

edited

Loading

claude bot commented Dec 4, 2025 •

edited

Loading

1. Type Error in `event-card.svelte` (Line 87-107)

2. Type Error in `schedule-input.svelte`

1. Potential Logic Issue in `event-details-full.svelte`