Skip to content

Conversation

@GraceGardner
Copy link
Contributor

Description & motivation 💭

Screenshots (if applicable) 📸

Design Considerations 🎨

Testing 🧪

How was this tested 👻

  • Manual testing
  • E2E tests added
  • Unit tests added

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

Checklists

Draft Checklist

Merge Checklist

Issue(s) closed

Docs

Any docs updates needed?

@GraceGardner GraceGardner requested a review from a team as a code owner December 15, 2025 21:03
@GraceGardner GraceGardner requested review from laurakwhit and removed request for a team December 15, 2025 21:03
@vercel
Copy link

vercel bot commented Dec 15, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
holocene Ready Ready Preview, Comment Dec 18, 2025 10:07pm

Copy link
Collaborator

@rossnelson rossnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! The move to runes is a great choice.

@temporal-cicd
Copy link
Contributor

temporal-cicd bot commented Dec 16, 2025

Warnings
⚠️

📊 Strict Mode: 26 errors in 3 files (2.0% of 1282 total)

src/routes/(app)/nexus/[id]/+page.svelte (2)
  • L25:18: Type 'NexusEndpoint | undefined' is not assignable to type 'NexusEndpoint'.
  • L27:24: Type 'NexusEndpoint | undefined' is not assignable to type 'IEndpoint'.
src/routes/(app)/nexus/[id]/edit/+page.svelte (17)
  • L34:14: 'endpoint' is possibly 'undefined'.
  • L35:19: 'endpoint' is possibly 'undefined'.
  • L38:28: 'body.spec' is possibly 'undefined'.
  • L41:4: 'body.spec' is possibly 'undefined'.
  • L41:28: Element implicitly has an 'any' type because expression of type '0' can't be used to index type 'IPayloads'.
  • L43:11: 'body.spec' is possibly 'undefined'.
  • L44:11: 'body.spec' is possibly 'undefined'.
  • L47:32: 'endpoint' is possibly 'undefined'.
  • L47:32: Argument of type 'string | null | undefined' is not assignable to parameter of type 'string'.
  • L48:33: 'endpoint' is possibly 'undefined'.
  • L48:33: Argument of type 'string | null | undefined' is not assignable to parameter of type 'string'.
  • L61:32: 'endpoint' is possibly 'undefined'.
  • L61:32: Argument of type 'string | null | undefined' is not assignable to parameter of type 'string'.
  • L61:52: 'endpoint' is possibly 'undefined'.
  • L72:15: 'namespace.namespaceInfo' is possibly 'undefined'.
  • L85:5: Type 'NexusEndpoint | undefined' is not assignable to type 'NexusEndpoint'.
  • L87:5: Type '{ namespace: string | null | undefined; }[]' is not assignable to type '{ namespace: string; }[]'.
src/routes/(app)/nexus/create/+page.svelte (7)
  • L30:30: 'body.spec' is possibly 'undefined'.
  • L33:6: 'body.spec' is possibly 'undefined'.
  • L33:30: Element implicitly has an 'any' type because expression of type '0' can't be used to index type 'IPayloads'.
  • L35:13: 'body.spec' is possibly 'undefined'.
  • L36:13: 'body.spec' is possibly 'undefined'.
  • L54:17: 'namespace.namespaceInfo' is possibly 'undefined'.
  • L66:5: Type '{ namespace: string | null | undefined; }[]' is not assignable to type '{ namespace: string; }[]'.

Generated by 🚫 dangerJS against c1be515

Copy link
Collaborator

@rossnelson rossnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good on your end. just noticed some preexisting stuff that might be worth addressing.

@Alex-Tideman
Copy link
Collaborator

We should keep our tables consistent in Nexus with all our other tables

Screenshot 2025-12-19 at 10 22 20 AM Screenshot 2025-12-19 at 10 22 33 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants