Skip to content

Conversation

@ceme393
Copy link
Contributor

@ceme393 ceme393 commented Feb 17, 2025

Description

📝 Please include a summary of the change.

  • Please also include relevant motivation and context.
  • List any dependencies that are required for this change.
    using the provided document lead to error of tf_keras module not being found. I added installation of tf-keras package in the instructions which fixes it.

Type of change

For a new feature or function, please create an issue first to discuss it
with us before submitting a pull request.

Note: Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • [ .] Documentation update
  • TensorFlow 2 migration
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • A new research paper code implementation
  • Other (Specify)

Tests

📝 Please describe the tests that you ran to verify your changes.

  • Provide instructions so we can reproduce.
  • Please also list any relevant details for your test configuration.
    try running python yamnet_test.py without first installing tf-keras package and then after installing it.
    Test Configuration:

Checklist

  • [ .] I have signed the Contributor License Agreement.
  • [ .] I have read guidelines for pull request.
  • [. ] My code follows the coding guidelines.
  • [. ] I have performed a self code review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • [. ] I have made corresponding changes to the documentation.
  • [ .] My changes generate no new warnings.
  • I have added tests that prove my fix is effective or that my feature works.

@ceme393 ceme393 requested review from dpwe and plakal as code owners February 17, 2025 12:22
@google-cla
Copy link

google-cla bot commented Feb 17, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@plakal plakal changed the title Fix error of not founding tf_keras module Fix tf-keras installation error Feb 18, 2025
Copy link
Collaborator

@plakal plakal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! I could swear these installation instructions worked without having to install tf-keras when I last updated the README, because keras is included in tensorflow. It's possible they have been separated since then.

@plakal plakal merged commit c14bf9a into tensorflow:master Feb 18, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants