Skip to content

feat(clickhouse): add HttpWaitStrategy instead of deprecated wait_container_is_ready #962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dzhalaevd wants to merge 1 commit into
base: main
Choose a base branch
from
+3 −8
Open

feat(clickhouse): add HttpWaitStrategy instead of deprecated wait_container_is_ready #962

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 3 additions & 8 deletions modules/clickhouse/testcontainers/clickhouse/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,12 +12,10 @@
# under the License.
import os
from typing import Optional
from urllib.error import HTTPError, URLError
from urllib.request import urlopen

from testcontainers.core.generic import DbContainer
from testcontainers.core.utils import raise_for_deprecated_parameter
from testcontainers.core.waiting_utils import wait_container_is_ready
from testcontainers.core.wait_strategies import HttpWaitStrategy


class ClickHouseContainer(DbContainer):
Expand Down Expand Up @@ -58,12 +56,9 @@ def __init__(
self.with_exposed_ports(self.port)
self.with_exposed_ports(8123)

@wait_container_is_ready(HTTPError, URLError)
def _connect(self) -> None:
# noinspection HttpUrlsUsage
url = f"http://{self.get_container_host_ip()}:{self.get_exposed_port(8123)}"
with urlopen(url) as r:
assert b"Ok" in r.read()
strategy = HttpWaitStrategy(8123).for_response_predicate(lambda response: "Ok" in response)
strategy.wait_until_ready(self)

def _configure(self) -> None:
self.with_env("CLICKHOUSE_USER", self.username)
Expand Down