Skip to content

Clear force_failure in _reset() #564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jelmer merged 1 commit into from
Feb 10, 2026
Merged

Clear force_failure in _reset() #564

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions NEWS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@ NEXT

Improvements
------------
* Clear ``force_failure`` in ``_reset()`` so that re-running a test
after an ``expectThat`` failure can succeed if successful conditions are met again.
(OumarCamara, #563)

* Make ``extract_result()`` and ``DeferredNotFired`` public APIs in
``testtools.twistedsupport``. These utilities are useful for extracting
Expand Down
3 changes: 3 additions & 0 deletions testtools/testcase.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,6 +307,9 @@ def _reset(self) -> None:
# __details is lazy-initialized so that a constructed-but-not-run
# TestCase is safe to use with clone_test_with_new_id.
self.__details: DetailsDict | None = None
# force_failure is set by expectThat() on mismatch; must be
# cleared so re-runs of the same test can succeed.
self.force_failure: bool | None = None

def __eq__(self, other: object) -> bool:
eq = getattr(unittest.TestCase, "__eq__", None)
Expand Down