Skip to content

fix(no-wait-for-side-effects): detect await expressions #1008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Belco90 merged 5 commits into from
May 26, 2025
Merged

fix(no-wait-for-side-effects): detect await expressions #1008

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bb3ced4
fix: `no-wait-for-side-effects` doesn't detect await expression
StyleShit May 15, 2025
712e32c
test: change test case
StyleShit May 18, 2025
eb4c965
Merge remote-tracking branch 'testing-library/main' into fix/742-get-…
StyleShit May 18, 2025
9d48f3c
Merge remote-tracking branch 'testing-library/main' into fix/742-get-…
StyleShit May 25, 2025
1e27b58
fix: redundant condition
StyleShit May 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/node-utils/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,6 +374,10 @@ export function getPropertyIdentifierNode(
return getPropertyIdentifierNode(node.expression);
}

if (ASTUtils.isAwaitExpression(node)) {
return getPropertyIdentifierNode(node.argument);
}

return null;
}

Expand Down
24 changes: 24 additions & 0 deletions tests/lib/rules/no-wait-for-side-effects.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,16 @@ ruleTester.run(RULE_NAME, rule, {
// Side effects are allowed inside .then()
userEvent.click(button);
})
`,
},
{
code: `
import { waitFor } from '${testingFramework}';
import { notUserEvent } from 'somewhere-else';

waitFor(() => {
await notUserEvent.click(button)
})
`,
},
]),
Expand Down Expand Up @@ -797,5 +807,19 @@ ruleTester.run(RULE_NAME, rule, {
],
} as const,
]),

...SUPPORTED_TESTING_FRAMEWORKS.flatMap((testingFramework) => [
{
code: `
import { waitFor } from '${testingFramework}';
import userEvent from '@testing-library/user-event'

await waitFor(() => {
await userEvent.click(button);
})
`,
errors: [{ line: 6, column: 11, messageId: 'noSideEffectsWaitFor' }],
},
]),
],
});