Refactor: can use MOOC.fi tokens to authenticate#541
Draft
Refactor: can use MOOC.fi tokens to authenticate#541
Conversation
|
Analysis results are not available for those commits View more on Code Climate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
validateendpoint to see if it's a user there/api/userendpoint to update the userupstream_id(ie. TMC id) thereupstream_idin MOOC.fiRelies on the
/auth/validatePOST and/api/userPATCH endpoints to be there in MOOC.fi, which they currently are not in the master branch.Needs two new envs:
moocfi_update_secretis the secret token used to update the user in MOOC.fi;base_url_for_moocfiis the backend URL ie.https://www.mooc.fi