Skip to content

dp: Fixes for DP scheduling #10488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
serhiy-katsyuba-intel wants to merge 2 commits into
base: main
Choose a base branch
from
+7 −21
Open

dp: Fixes for DP scheduling #10488

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
98a8ddb
dp: Allow scheduling of already running DP task
serhiy-katsyuba-intel Jan 16, 2026
bd2bdca
idc: dp: Remove redundant switch code
serhiy-katsyuba-intel Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 1 addition & 21 deletions src/idc/idc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,32 +222,12 @@ static int idc_trigger(uint32_t comp_id)
struct idc *idc = *idc_get();
struct idc_payload *payload = idc_payload_get(idc, cpu_get_id());
uint32_t cmd = *(uint32_t *)payload;
int ret;

ipc_dev = ipc_get_comp_by_id(ipc, comp_id);
if (!ipc_dev)
return -ENODEV;

ret = comp_trigger(ipc_dev->cd, cmd);
if (ret < 0)
goto out;

/* schedule or cancel task */
switch (cmd) {
case COMP_TRIGGER_START:
case COMP_TRIGGER_RELEASE:
schedule_task(ipc_dev->cd->task, 0, ipc_dev->cd->period);
break;
case COMP_TRIGGER_XRUN:
case COMP_TRIGGER_PAUSE:
case COMP_TRIGGER_STOP:
schedule_task_cancel(ipc_dev->cd->task);
break;
}

out:

return ret;
return comp_trigger(ipc_dev->cd, cmd);
}

/**
Expand Down
6 changes: 6 additions & 0 deletions src/schedule/zephyr_dp_schedule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,6 +325,12 @@ static int scheduler_dp_task_shedule(void *data, struct task *task, uint64_t sta

lock_key = scheduler_dp_lock(cpu_get_id());

if (task_is_active(task)) {
scheduler_dp_unlock(lock_key);
tr_dbg(&dp_tr, "DP task already active");
return 0;
}

if (task->state != SOF_TASK_STATE_INIT &&
task->state != SOF_TASK_STATE_CANCEL &&
task->state != SOF_TASK_STATE_COMPLETED) {
Expand Down