-
Notifications
You must be signed in to change notification settings - Fork 630
Version Packages #8554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Version Packages #8554
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
WalkthroughRemoved several .changeset files, added/updated changelog entries, and bumped package/app versions; no source code or exported/public API declarations were modified. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Pre-merge checks and finishing touches❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro Disabled knowledge base sources:
📒 Files selected for processing (15)
💤 Files with no reviewable changes (7)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (5)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
🔇 Additional comments (2)
Comment |
7064dc8 to
f7c9199
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (10)
.changeset/ninety-trains-tell.md(0 hunks).changeset/violet-needles-fly.md(0 hunks)apps/wagmi-demo/CHANGELOG.md(1 hunks)apps/wagmi-demo/package.json(1 hunks)packages/nebula/CHANGELOG.md(1 hunks)packages/nebula/package.json(1 hunks)packages/thirdweb/CHANGELOG.md(1 hunks)packages/thirdweb/package.json(1 hunks)packages/wagmi-adapter/CHANGELOG.md(1 hunks)packages/wagmi-adapter/package.json(1 hunks)
💤 Files with no reviewable changes (2)
- .changeset/ninety-trains-tell.md
- .changeset/violet-needles-fly.md
🧰 Additional context used
📓 Path-based instructions (2)
**/*.{js,jsx,ts,tsx,json}
📄 CodeRabbit inference engine (AGENTS.md)
Biome governs formatting and linting; its rules live in biome.json. Run
pnpm fix&pnpm lintbefore committing, ensure there are no linting errors
Files:
packages/wagmi-adapter/package.jsonpackages/nebula/package.jsonapps/wagmi-demo/package.jsonpackages/thirdweb/package.json
packages/thirdweb/package.json
📄 CodeRabbit inference engine (CLAUDE.md)
Track bundle budgets via
package.json#size-limit
Files:
packages/thirdweb/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
- GitHub Check: E2E Tests (pnpm, vite)
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: E2E Tests (pnpm, webpack)
- GitHub Check: Unit Tests
- GitHub Check: Size
- GitHub Check: Build Packages
- GitHub Check: Lint Packages
- GitHub Check: Analyze (javascript)
🔇 Additional comments (7)
packages/nebula/package.json (1)
60-60: Version bump looks consistent with a patch release.
No concerns in this file beyond the version increment.apps/wagmi-demo/package.json (1)
4-4: Private app version bump is fine.
No other changes/risk in this file.packages/wagmi-adapter/package.json (1)
59-59: Patch version bump looks correct; peer range remains compatible.
thirdweb@5.116.2is withinpeerDependencies.thirdweb: ^5.85.0, so this release bump is consistent.packages/thirdweb/package.json (1)
433-433: Version bump only; please ensure bundle budgets still pass.Since
packages/thirdweb/package.jsontracks bundle budgets viasize-limit, it's worth confirmingpnpm -C packages/thirdweb sizeandpnpm lintremain green. (CI will also verify these on the PR via the size and lint jobs.)packages/thirdweb/CHANGELOG.md (1)
3-10: Changelog entry looks consistent and correctly scoped to patch notes.
5.116.2is added at the top, uses the same heading structure as prior entries, and clearly attributes PRs/commits/authors for the two fixes.packages/nebula/CHANGELOG.md (1)
3-9: Changelog entry looks consistent and complete for a dependency-only patch release.apps/wagmi-demo/CHANGELOG.md (1)
3-10: Changelog entry is clear and matches the established “Updated dependencies” format.
| ## 0.2.201 | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Avoid empty changelog sections; add at least a minimal “Patch Changes” note for 0.2.201.
Suggested patch:
## 0.2.201
+
+### Patch Changes
+
+- No user-facing changes.📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| ## 0.2.201 | |
| ## 0.2.201 | |
| ### Patch Changes | |
| - No user-facing changes. |
🤖 Prompt for AI Agents
In packages/wagmi-adapter/CHANGELOG.md around lines 3 to 4, the 0.2.201 entry is
empty; add a minimal "Patch Changes" section under the version header with
one-line note describing the patch (e.g., "Patch Changes: minor fixes and
documentation updates" or the actual fix summary). Update the file so 0.2.201
includes the "Patch Changes" heading and a concise bullet or sentence, commit
the change.
size-limit report 📦
|
f7c9199 to
cd790c9
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8554 +/- ##
==========================================
- Coverage 53.19% 53.18% -0.01%
==========================================
Files 922 922
Lines 61480 61480
Branches 4032 4032
==========================================
- Hits 32706 32701 -5
- Misses 28676 28681 +5
Partials 98 98
🚀 New features to boost your workflow:
|
cd790c9 to
ad13a2c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/thirdweb/CHANGELOG.md (1)
3-14: Changelog entry looks correct; consider normalizing wording/capitalization (“UI”).
New5.116.2section is well-formed and links look consistent. Minor nit: “wide connect ui” → “wide connect UI” to match surrounding style.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (11)
.changeset/eager-loops-obey.md(0 hunks).changeset/ninety-trains-tell.md(0 hunks).changeset/violet-needles-fly.md(0 hunks)apps/wagmi-demo/CHANGELOG.md(1 hunks)apps/wagmi-demo/package.json(1 hunks)packages/nebula/CHANGELOG.md(1 hunks)packages/nebula/package.json(1 hunks)packages/thirdweb/CHANGELOG.md(1 hunks)packages/thirdweb/package.json(1 hunks)packages/wagmi-adapter/CHANGELOG.md(1 hunks)packages/wagmi-adapter/package.json(1 hunks)
💤 Files with no reviewable changes (3)
- .changeset/violet-needles-fly.md
- .changeset/eager-loops-obey.md
- .changeset/ninety-trains-tell.md
🚧 Files skipped from review as they are similar to previous changes (4)
- packages/thirdweb/package.json
- packages/wagmi-adapter/CHANGELOG.md
- packages/nebula/package.json
- apps/wagmi-demo/package.json
🧰 Additional context used
📓 Path-based instructions (1)
**/*.{js,jsx,ts,tsx,json}
📄 CodeRabbit inference engine (AGENTS.md)
Biome governs formatting and linting; its rules live in biome.json. Run
pnpm fix&pnpm lintbefore committing, ensure there are no linting errors
Files:
packages/wagmi-adapter/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
- GitHub Check: Size
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: E2E Tests (pnpm, webpack)
- GitHub Check: E2E Tests (pnpm, vite)
- GitHub Check: Build Packages
- GitHub Check: Lint Packages
- GitHub Check: Unit Tests
- GitHub Check: Analyze (javascript)
🔇 Additional comments (3)
packages/wagmi-adapter/package.json (1)
59-59: Version bump looks consistent for release automation.Only metadata change; aligns with the release PR intent.
apps/wagmi-demo/CHANGELOG.md (1)
1-10: No action needed — changelog header and dependencies are correct.The package name
wagmi-inappin the changelog header matchesapps/wagmi-demo/package.json, version0.0.46is correct, and the declared dependency versions (@thirdweb-dev/wagmi-adapter@0.2.201) align with the entry. The app usesworkspace:*references, which is appropriate for this monorepo structure.packages/nebula/CHANGELOG.md (1)
3-8: Changelog entry looks good.The new version 0.2.104 entry is properly formatted and consistent with existing entries. The commit references and dependency update to thirdweb@5.116.2 align with the PR objectives. The patch version bump is appropriate for dependency-only updates.
ad13a2c to
fa097ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
packages/thirdweb/CHANGELOG.md (1)
3-13: Changelog entry looks correct; tiny wording nitThe 5.116.2 entry correctly lists the four PRs described in the PR summary and matches existing formatting. The only tiny consistency nit is “wide connect ui” in Line 11 — elsewhere in the changelog similar phrases use “UI” uppercase. Consider changing
wide connect ui→wide connect UIfor consistency, but it’s purely editorial.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (12)
.changeset/eager-loops-obey.md(0 hunks).changeset/ninety-trains-tell.md(0 hunks).changeset/sixty-clubs-fix.md(0 hunks).changeset/violet-needles-fly.md(0 hunks)apps/wagmi-demo/CHANGELOG.md(1 hunks)apps/wagmi-demo/package.json(1 hunks)packages/nebula/CHANGELOG.md(1 hunks)packages/nebula/package.json(1 hunks)packages/thirdweb/CHANGELOG.md(1 hunks)packages/thirdweb/package.json(1 hunks)packages/wagmi-adapter/CHANGELOG.md(1 hunks)packages/wagmi-adapter/package.json(1 hunks)
💤 Files with no reviewable changes (4)
- .changeset/ninety-trains-tell.md
- .changeset/eager-loops-obey.md
- .changeset/violet-needles-fly.md
- .changeset/sixty-clubs-fix.md
✅ Files skipped from review due to trivial changes (1)
- apps/wagmi-demo/CHANGELOG.md
🚧 Files skipped from review as they are similar to previous changes (4)
- packages/wagmi-adapter/package.json
- packages/thirdweb/package.json
- packages/wagmi-adapter/CHANGELOG.md
- apps/wagmi-demo/package.json
🧰 Additional context used
📓 Path-based instructions (1)
**/*.{js,jsx,ts,tsx,json}
📄 CodeRabbit inference engine (AGENTS.md)
Biome governs formatting and linting; its rules live in biome.json. Run
pnpm fix&pnpm lintbefore committing, ensure there are no linting errors
Files:
packages/nebula/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
- GitHub Check: E2E Tests (pnpm, webpack)
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: Build Packages
- GitHub Check: Lint Packages
- GitHub Check: Unit Tests
- GitHub Check: E2E Tests (pnpm, vite)
- GitHub Check: Size
- GitHub Check: Analyze (javascript)
🔇 Additional comments (2)
packages/nebula/package.json (1)
60-60: LGTM! Version bump is correct.The patch version increment from 0.2.103 to 0.2.104 aligns with the automated release process and matches the corresponding CHANGELOG entry.
packages/nebula/CHANGELOG.md (1)
3-9: LGTM! Changelog entry is well-formed.The new 0.2.104 release entry correctly documents the dependency update to thirdweb@5.116.2 with proper commit references, consistent with the automated release process.
fa097ae to
e719db6
Compare
010c181 to
07652ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
packages/thirdweb/CHANGELOG.md (1)
17-17: Optional: Normalize “UI” capitalizationHere you use
wide connect uiwhile other entries (e.g., line 19) capitalize “UI”. Consider changing this towide connect UIfor consistency with the rest of the changelog.
📜 Review details
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (13)
.changeset/eager-loops-obey.md(0 hunks).changeset/ninety-trains-tell.md(0 hunks).changeset/sixty-clubs-fix.md(0 hunks).changeset/violet-needles-fly.md(0 hunks).changeset/yummy-squids-rush.md(0 hunks)apps/wagmi-demo/CHANGELOG.md(1 hunks)apps/wagmi-demo/package.json(1 hunks)packages/nebula/CHANGELOG.md(1 hunks)packages/nebula/package.json(1 hunks)packages/thirdweb/CHANGELOG.md(1 hunks)packages/thirdweb/package.json(1 hunks)packages/wagmi-adapter/CHANGELOG.md(1 hunks)packages/wagmi-adapter/package.json(1 hunks)
💤 Files with no reviewable changes (5)
- .changeset/eager-loops-obey.md
- .changeset/ninety-trains-tell.md
- .changeset/sixty-clubs-fix.md
- .changeset/yummy-squids-rush.md
- .changeset/violet-needles-fly.md
🚧 Files skipped from review as they are similar to previous changes (5)
- packages/thirdweb/package.json
- packages/wagmi-adapter/CHANGELOG.md
- packages/nebula/package.json
- apps/wagmi-demo/package.json
- packages/nebula/CHANGELOG.md
🧰 Additional context used
📓 Path-based instructions (1)
**/*.{js,jsx,ts,tsx,json}
📄 CodeRabbit inference engine (AGENTS.md)
Biome governs formatting and linting; its rules live in biome.json. Run
pnpm fix&pnpm lintbefore committing, ensure there are no linting errors
Files:
packages/wagmi-adapter/package.json
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)
- GitHub Check: Unit Tests
- GitHub Check: E2E Tests (pnpm, esbuild)
- GitHub Check: E2E Tests (pnpm, webpack)
- GitHub Check: E2E Tests (pnpm, vite)
- GitHub Check: Size
- GitHub Check: Build Packages
- GitHub Check: Lint Packages
- GitHub Check: Analyze (javascript)
🔇 Additional comments (2)
packages/wagmi-adapter/package.json (1)
59-59: LGTM! Version bump is correct.The patch version increment from 0.2.200 to 0.2.201 follows semantic versioning conventions and aligns with the automated release workflow.
apps/wagmi-demo/CHANGELOG.md (1)
3-10: LGTM! Changelog entry is well-formatted.The new version 0.0.46 entry correctly documents the dependency updates with proper commit references and follows the established changelog format.
|
|
||
| ### Minor Changes | ||
|
|
||
| - [#8579](https://github.com/thirdweb-dev/js/pull/8579) [`304e4e5`](https://github.com/thirdweb-dev/js/commit/304e4e5be860e4989abf0493cb737f46e050a697) Thanks [@MananTank](https://github.com/MananTank)! - Remove in-app wallet from default wallet list for bridge widgets" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove stray trailing quote in minor-change description
The line ends with an extra " after bridge widgets, which looks like a typo and is inconsistent with other entries. Please remove the trailing quote.
🤖 Prompt for AI Agents
In packages/thirdweb/CHANGELOG.md around line 7, there is a stray trailing
double-quote at the end of the minor-change entry: remove the extra `"` after
"bridge widgets" so the line matches other entries (i.e., end the line with the
closing parenthesis and description only, no trailing quote).
07652ee to
129a7e0
Compare
129a7e0 to
2b156f8
Compare
This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.
Releases
thirdweb@5.117.0
Minor Changes
304e4e5Thanks @MananTank! - Remove in-app wallet from default wallet list for bridge widgets"Patch Changes
#8573
9c04b3fThanks @MananTank! - More reliable list of chains shown in token selection UI in SwapWidget based on origin and destination chain selections#8552
5ec84bdThanks @MananTank! - Token Selection UX improvements in SwapWidget#8580
0ff8b9fThanks @MananTank! - Move directly to token selection screen after connecting wallet in "Choose Payment" screen instead of showing the "Choose Payment" screen again after connecting wallet in bridge widgets#8551
31e24f1Thanks @MananTank! - Alphabetically sort the chains in SwapWidget UI#8578
fdd2557Thanks @MananTank! - Remove fiat price shown in the button inCheckoutWidgetto avoid showing it twice in the UI.#8556
151127dThanks @MananTank! - Update in-app wallet icon in wide connect ui#8553
38f4a89Thanks @MananTank! - Fix Spinner animation not working sometimes in Next.js#8576
56a1c0aThanks @MananTank! - Payment Details UI improvements for bridge widget components@thirdweb-dev/nebula@0.2.104
Patch Changes
9c04b3f,5ec84bd,0ff8b9f,31e24f1,304e4e5,fdd2557,151127d,38f4a89,56a1c0a]:@thirdweb-dev/wagmi-adapter@0.2.201
wagmi-inapp@0.0.46
Patch Changes
9c04b3f,5ec84bd,0ff8b9f,31e24f1,304e4e5,fdd2557,151127d,38f4a89,56a1c0a]:PR-Codex overview
This PR primarily focuses on version updates across multiple packages, along with the addition of changelog entries for the updated versions. It includes dependency updates and improvements to the
thirdwebandwagmipackages.Detailed summary
.changesetmarkdown files.versioninpackages/thirdweb/package.jsonfrom5.116.1to5.117.0.versioninapps/wagmi-demo/package.jsonfrom0.0.45to0.0.46.versioninpackages/nebula/package.jsonfrom0.2.103to0.2.104.versioninpackages/wagmi-adapter/package.jsonfrom0.2.200to0.2.201.packages/nebulaversion0.2.104.apps/wagmi-demoversion0.0.46.packages/thirdwebversion5.117.0with various improvements and bug fixes.Summary by CodeRabbit
Bug Fixes
Improvements
Chores
✏️ Tip: You can customize this high-level summary in your review settings.