Skip to content

Conversation

@MananTank
Copy link
Contributor

@MananTank MananTank commented Feb 8, 2026

Fixes spacing issue on sidebar

Before

image

After

image

PR-Codex overview

This PR focuses on enhancing the SidebarItem component by adding an isFirst prop to manage specific styling for the first item in the sidebar.

Detailed summary

  • Added isFirst prop to SidebarItem to indicate if it is the first item.
  • Updated the DocSidebarNonCollapsible component to apply conditional styling based on the isFirst prop.
  • Adjusted the rendering of SidebarItem in multiple places to pass the isFirst prop.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

Summary by CodeRabbit

  • Style
    • Enhanced sidebar spacing and alignment for improved visual consistency across the entire navigation section. Removed unnecessary top padding from the sidebar header and optimized spacing distribution for first items in categories, resulting in better layout harmony and a more refined appearance throughout the navigation interface.

@MananTank MananTank requested review from a team as code owners February 8, 2026 11:59
@changeset-bot
Copy link

changeset-bot bot commented Feb 8, 2026

⚠️ No Changeset found

Latest commit: ca7dce8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Feb 8, 2026

@MananTank is attempting to deploy a commit to the thirdweb Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added the Portal Involves changes to the Portal (docs) codebase. label Feb 8, 2026
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 8, 2026

Walkthrough

Two sidebar layout adjustments: removed top padding from DocSidebar header, and introduced an isFirst boolean prop that propagates through SidebarItem and DocSidebarNonCollapsible to conditionally apply top margin styling to first items in sidebar lists.

Changes

Cohort / File(s) Summary
Sidebar spacing adjustments
apps/portal/src/components/Layouts/DocLayout.tsx, apps/portal/src/components/others/Sidebar.tsx
Removed pt-1 padding class from DocSidebar. Added isFirst prop propagation (DocSidebar → SidebarItem → DocSidebarNonCollapsible) to apply conditional mt-0 top margin for first sidebar items, with nested item detection for subsequent list levels.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 1 | ❌ 2
❌ Failed checks (2 warnings)
Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
Description check ⚠️ Warning The PR description lacks the required template structure including title format, issue tag, reviewer notes, and testing instructions. Use the provided template format. Add a properly formatted title like '[Portal] Fix: Sidebar spacing on top', include issue tag if available, provide reviewer notes, and specify how to test the changes (e.g., visual verification on docs site).
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: removing top padding from the sidebar to fix spacing issues.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@MananTank
Copy link
Contributor Author

++ @joaquim-verges

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Portal Involves changes to the Portal (docs) codebase.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant