-
Notifications
You must be signed in to change notification settings - Fork 0
161 - make product pill align #213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Review complete. All issues have been addressed.
Mention @roomote in a comment to request specific changes to this pull request or fix all unresolved issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed some inconsistent styling, hence this change. (Specifically remix-callout buttons)
| const activeTab = tabs.find((tab) => tab.name.toLowerCase() === activeChainType.toLowerCase()) | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If tabs is an empty array, activeTab will be undefined and tabs[0] will also be undefined, causing displayTab.links on line 39 to throw a runtime error. Consider adding a guard clause or early return for empty arrays.
| const activeTab = tabs.find((tab) => tab.name.toLowerCase() === activeChainType.toLowerCase()) | |
| const displayTab = activeTab || tabs[0] | |
| if (!displayTab) { | |
| return null | |
| } |
Fix it with Roo Code or mention @roomote and request a fix.
No description provided.