Skip to content

Fix TypeError when adding subcategory to group-restricted parent category #3723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thorsten merged 4 commits into from
Nov 2, 2025
Merged

Fix TypeError when adding subcategory to group-restricted parent category #3723

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f275572
Initial plan
Copilot Nov 1, 2025
4ad9905
Fix fatal error when adding subcategory to restricted parent category
Copilot Nov 1, 2025
4e9ecf6
Add validation for category data retrieval
Copilot Nov 1, 2025
9887a3f
Remove unnecessary null coalescing operator
Copilot Nov 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 25 additions & 2 deletions phpmyfaq/admin/category.add.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
* @since 2003-12-20
*/

use phpMyFAQ\Category;
use phpMyFAQ\Category\Permission;
use phpMyFAQ\Enums\PermissionType;
use phpMyFAQ\Filter;
Expand Down Expand Up @@ -75,12 +76,34 @@
if ($parentId > 0) {
$userAllowed = $categoryPermission->get(Permission::USER, [$parentId]);
$groupsAllowed = $categoryPermission->get(Permission::GROUP, [$parentId]);

// Check if parent category exists in loaded categories
// If not (due to permission restrictions), fetch it directly
if (!isset($category->categoryName[$parentId])) {
$baseCategory = new Category($faqConfig, [], false);
$baseCategory->setLanguage($faqConfig->getLanguage()->getLanguage());
$parentCategoryData = $baseCategory->getCategoryData($parentId);

// Validate that the category was found
if ($parentCategoryData->getId() > 0) {
$parentCategoryLang = $parentCategoryData->getLang();
$parentCategoryName = $parentCategoryData->getName();
} else {
// Parent category doesn't exist in database - use fallback values
$parentCategoryLang = $faqConfig->getLanguage()->getLanguage();
$parentCategoryName = '';
}
} else {
$parentCategoryLang = $category->categoryName[$parentId]['lang'];
$parentCategoryName = $category->categoryName[$parentId]['name'];
}

$templateVars = [
...$templateVars,
'categoryNameLangCode' => LanguageCodes::get($category->categoryName[$parentId]['lang']),
'categoryNameLangCode' => LanguageCodes::get($parentCategoryLang),
'userAllowed' => $categoryPermission->get(Permission::USER, [$parentId])[0],
'groupsAllowed' => $categoryPermission->get(Permission::GROUP, [$parentId]),
'categoryName' => $category->categoryName[$parentId]['name'],
'categoryName' => $parentCategoryName,
'msgMainCategory' => Translation::get('msgMainCategory'),
];
}
Expand Down