This repository was archived by the owner on Jul 19, 2019. It is now read-only.
Migrate to Reason + add Identity submodule in preparation for further additions#3
Open
jchavarri wants to merge 1 commit intothoughtbot:masterfrom
Open
Migrate to Reason + add Identity submodule in preparation for further additions#3jchavarri wants to merge 1 commit intothoughtbot:masterfrom
jchavarri wants to merge 1 commit intothoughtbot:masterfrom
Conversation
…dditions to Chrome
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for these bindings @sidraval ! I'm currently working on some Chrome extensions and was planning to contribute some additions to this repo.
Before doing so, would you consider migrating it to Reason? I find myself much more comfortable with it coming from a JS background :) but I'm not sure if it'd be ok.
If you find that is a good idea, I've created this PR, where all files are
.reand the example compiles. I also created a new fileIdentityReso in the future others can be added (ExtensionReetc).