-
Notifications
You must be signed in to change notification settings - Fork 8
[SCAL-289371] - feat(spotter): add sidebar embed actions, events, params, and CSS variables #402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @ravishah8176, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the customization capabilities of the Spotter past conversations sidebar within the SDK. It provides developers with extensive control over the sidebar's appearance, behavior, and interactive elements through new CSS variables, embed configuration parameters, and action controls. Additionally, it introduces new events to allow external applications to react to key conversation lifecycle changes, such as renaming, deleting, or selecting a chat. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces extensive customization options for the Spotter past conversations sidebar, adding new actions, events, parameters, and CSS variables to control its appearance and behavior. However, a critical security vulnerability has been identified: new string-based configuration options are used to construct a URL without proper encoding, leading to a high-risk Cross-Site Scripting (XSS) and HTTP Parameter Pollution vulnerability. This could allow attackers to inject malicious JavaScript or manipulate URL parameters, potentially compromising user accounts. It is crucial to properly encode all user-provided values before they are used in the URL. Additionally, there's a suggestion to refactor a series of if statements to improve code maintainability.
05c7218 to
adc3aa9
Compare
adc3aa9 to
6a2e604
Compare
|
SonarQube Quality Gate
See analysis details on SonarQube Fix issues before they fail your Quality Gate with |



Add SDK support for Spotter past conversations sidebar customization:
SpotterSidebarHeader,SpotterNewChat,SpotterChatRename, etc.)SpotterConversationRenamed,SpotterConversationDeleted,SpotterConversationSelected)Version: SDK 1.46.0 | ThoughtSpot 26.3.0.cl